FreeBSD_stable_10 - Build #1847 - Fixed

[jenkins-admin at FreeBSD.org]

FreeBSD_stable_10 - Build #1847 - Fixed:

Build information: https://jenkins.FreeBSD.org/job/FreeBSD_stable_10/1847/
Full change log: https://jenkins.FreeBSD.org/job/FreeBSD_stable_10/1847/changes
Full build log: https://jenkins.FreeBSD.org/job/FreeBSD_stable_10/1847/console

Change summaries:

291389 by mav:
MFC r290820: Add NULL check to make Coverity happy.

291388 by mav:
MFC r290670: Modify target port groups logic in CTL.

 - Introduce "ha_shared" port option, which being set to "on" moves the
port into separate port group, shared between HA nodes.  This allows to
better handle cases when iSCSI portals are bound to CARP address that can
dynamically move between nodes.  Some initiators (at least VMware) don't
detect that after iSCSI reconnect they've attached to different SCSI port
from different port group, that totally breakes ALUA status parsing.
In theory, I believe, it should be enough to have different iSCSI portal
group tags on different nodes to make initiators detect this condition,
but it seems like VMware ignores those values, and even full LUN retaste
forced by UA does not help.
 - Make CTL report up to three port groups: 1 -- non-HA mode or ports
with "ha_shared" option set, 2 -- HA node 1, 3 -- HA node 2.
 - Report Transitioning state for all port groups when HA interlink is
connected, but neither of nodes is primary for the LUN.

291387 by mav:
MFC r290615: Introduce portal group options in ctl.conf.

While CTL has concept of port options, used at least for iSCSI ports now,
before this change it was impossible to set them manually.  There still
no user-configurable port options now, but I am planning to change that.