Possible Error in the FreeBSD 10.2 Release Notes/Man page for TCP

[Sean Bruno]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On 08/12/15 15:43, Glen Barber wrote:
> On Wed, Aug 12, 2015 at 03:41:21PM -0700, Sean Bruno wrote:
>> On 08/12/15 15:15, Glen Barber wrote:
>>> On Wed, Aug 12, 2015 at 01:09:31PM -0500, dweimer wrote:
>>>> I was reading through the Release notes, and decided to
>>>> enable net.inet.tcp.pmtud_blackhole_detection in my test
>>>> environment. It appears that the monitoring tunable 
>>>> net.inet.tcp.pmtud_blackhole_min_activated is incorrectly
>>>> listed. Using sysctl -a | grep net.inet.tcp.pmtud, doesn't
>>>> show it as a result. The test system is running RC3 built on
>>>> the 7th from revision 286391 of the
>>>> https://svn.freebsd.org/base/releng/10.2 tree.
>>>> 
>>>> root at freebsd:/usr/src # sysctl -a | grep net.inet.tcp.pmtud 
>>>> net.inet.tcp.pmtud_blackhole_mss: 1200 
>>>> net.inet.tcp.pmtud_blackhole_failed: 0 
>>>> net.inet.tcp.pmtud_blackhole_activated_min_mss: 0 
>>>> net.inet.tcp.pmtud_blackhole_activated: 0 
>>>> net.inet.tcp.pmtud_blackhole_detection: 1
>>>> 
>>>> I did confirm that the pmtud_blackhole_min_activated option
>>>> is also listed in the tcp(4) man page page as well.
>>>> 
>>>> If anyone is more familiar with this than I am can they look
>>>> into seeing if there is indeed an error, or if I am missing
>>>> something here.
>>>> 
>>> 
>>> This appears to be an error based on the content of the commit 
>>> log. I will confirm with the person that committed the code,
>>> and will note the findings in the 10.2-RELEASE errata
>>> document.
>>> 
>> 
>> This looks like I failed to MFC r276345 to stable 10 in order to 
>> update tcp.4 leading to this confusion.
>> 
> 
> Thank you for confirming.  I'll update the 10.2-RELEASE errata 
> accordingly.
> 
> What should the proper sysctls be, for completeness?
> 
> Glen
> 

% sysctl -a|grep pmtud
net.inet.tcp.v6pmtud_blackhole_mss: 1220
net.inet.tcp.pmtud_blackhole_mss: 1200
net.inet.tcp.pmtud_blackhole_failed: 0
net.inet.tcp.pmtud_blackhole_activated_min_mss: 0
net.inet.tcp.pmtud_blackhole_activated: 0
net.inet.tcp.pmtud_blackhole_detection: 0


These are correct.  The man page is now updated as of svn r286706.

sean
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQF8BAEBCgBmBQJVy86vXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRCQUFENDYzMkU3MTIxREU4RDIwOTk3REQx
MjAxRUZDQTFFNzI3RTY0AAoJEBIB78oecn5kyVMIAMPN8pFIgeGRX3bvqfZv5F8C
qt3hhZGKWXqsAd4Ij+74rmZQP/7bBGC6jQCyztnHyLy7zN6zKtEKaznP5kjOmsrw
96ovaOKskfTL4cBUUb8KSyvoyZ/v2JBlnc56loFsfJBJ1vG+7LfQKjYkCfMyhPh0
JWr0LzkNKve46yfZr84I9VXux5Y0lsIWxvaDJ+zA4ISzb6tWEZMuC+yxY6v6ubQk
zgkyrXUyFRs6taUWn3Mm3EdJKjbC0tOHwD1fAebRSZbmA0ZmkONWJlm3mshkU5Yd
nxfUYCs0n1let9cQ7QaKA+czkl3BV7oUfZ7QDcc54D5fb8AG1z8nehPfq2LGOL4=
=wVa0
-----END PGP SIGNATURE-----