getting to 4K disk blocks in ZFS

[Steven Hartland]

----- Original Message ----- 
From: "Willem Jan Withagen" <wjw at digiware.nl>
To: "Steven Hartland" <killing at multiplay.co.uk>; "Peter Wemm" <peter at wemm.org>; <freebsd-stable at freebsd.org>
Cc: "Andriy Gapon" <avg at freebsd.org>; "Aristedes Maniatis" <ari at ish.com.au>
Sent: Friday, September 12, 2014 9:29 AM
Subject: Re: getting to 4K disk blocks in ZFS


> On 12-9-2014 10:17, Steven Hartland wrote:
>> 
>> ----- Original Message ----- From: "Willem Jan Withagen" <wjw at digiware.nl>
>> 
>> 
>>> On 11-9-2014 19:49, Peter Wemm wrote:
>>>>> Another downside is 1/4th of uberblocks, 32 vs 128.
>>>>> Also, automatic sector size detection works great for me and I've
>>>>> never had
>>>>> a need to manually tweak ashift.
>>>>
>>>> Unfortunately, I have.  Same drive connected two different ways:
>>>>
>>>> da12 at mps1 bus 0 scbus1 target 11 lun 0
>>>> da12: <ATA ST4000VN000-1H41 SC43> Fixed Direct Access SCSI-6 device
>>>> da12: 600.000MB/s transfers
>>>> da12: Command Queueing enabled
>>>> da12: 3815447MB (7814037168 512 byte sectors: 255H 63S/T 486401C)
>>>>
>>>> ada1 at ahcich1 bus 0 scbus3 target 0 lun 0
>>>> ada1: <ATA ST4000VN000-1H41 SC43> ATA-8 SATA 3.x device
>>>> ada1: 600.000MB/s transfers (SATA 3.x, UDMA6, PIO 8192bytes)
>>>> ada1: Command Queueing enabled
>>>> ada1: 3815447MB (7814037168 512 byte sectors:  16H 63S/T 16383C)
>>>> ada1: quirks=0x1<4K>
>>>>
>>>> The 4k flag is missing when it's on the sas controller.  The Ident
>>>> strings are changed.
>>>>
>>>> This came up elsewhere recently.
>>>
>>> I reported the same fact for the new set of WD REDs I installed.
>>> Seems that ada and da have different quirks tables...
>>> So disks on SATA connectors on the motherboard are diagnosed as being
>>> 4Kb.
>>> The disks on my twa don't get the quirk and are considered 512b
>> 
>> LMK the ident strings and I'll look to update the quirks tables.
> 
> Hi Steven,
> 
> Well actually IMHO the quirk tables should be "joined".
> Because it is nowadays very simple to get a sata device on a scsi-device
> (da??) be it USB, or a controller that make the world look like
> /dev/da?? Like the twa I have.
> I guess the other way scis devices turning up under ATA would not be common.

You can't unfortunately as they report differently as you've found.

> That said, it will not be so simple, otherwise somebody(tm) would have
> done so already?
> 
> the WD RED under ata:
> ada4 at ahcich10 bus 0 scbus11 target 0 lun 0
> ada4: <WDC WD30EFRX-68AX9N0 80.00A80> ATA-9 SATA 3.x device
> ada4: Serial Number WD-WMC1T4089783
> ada4: 300.000MB/s transfers (SATA 2.x, UDMA6, PIO 8192bytes)
> ada4: Command Queueing enabled
> ada4: 2861588MB (5860533168 512 byte sectors: 16H 63S/T 16383C)
> ada4: quirks=0x1<4K>
> 
> under twa
> da0 at arcmsr0 bus 0 scbus8 target 0 lun 0
> da0: <WDC WD30EFRX-68AX9N0 R001> Fixed Direct Access SCSI-5 device
> da0: Serial Number WD-WMC1T4081674
> da0: 250.000MB/s transfers (125.000MHz, offset 32, 16bit)
> da0: Command Queueing enabled
> da0: 2861588MB (5860533168 512 byte sectors: 255H 63S/T 364801C)
> da0: Delete methods: <NONE(*)>

Looks like there are entries which should match already there:

        {
                /* WDC Caviar Green Advanced Format (4k) drives */
                { T_DIRECT, SIP_MEDIA_FIXED, "ATA", "WDC WD????RX*", "*" },
                /*quirks*/DA_Q_4K
        },
        {
                /* WDC Caviar Green Advanced Format (4k) drives */
                { T_DIRECT, SIP_MEDIA_FIXED, "WDC WD??", "??RX*", "*" },
                /*quirks*/DA_Q_4K
        },

What does camcontrol identify and camcontrol inquiry report?

    Regards
    Steve