10-STABLE Buildworld Failing

[Ian Lepore]

On Wed, 2014-09-10 at 13:27 -0500, Tim Daneliuk wrote:
> As of some recent SVN pulls (date unsure), we are seeing the problem below.
> Any thoughts or help most welcome:
> 
> 
> cc  -O2 -pipe 
> -I/usr/src/usr.bin/svn/svn/../../../contrib/subversion/subversion/include 
> -I/usr/src/usr.bin/svn/svn/../../../contrib/subversion/subversion -I/usr/src
> /usr.bin/svn/svn/..  -I/usr/src/usr.bin/svn/svn/../lib/libapr 
> -I/usr/src/usr.bin/svn/svn/../../../contrib/apr/include/arch/unix 
> -I/usr/src/usr.bin/svn/svn/../../../
> contrib/apr/include  -I/usr/src/usr.bin/svn/svn/../lib/libapr_util 
> -I/usr/src/usr.bin/svn/svn/../../../contrib/apr-util/include/private 
> -I/usr/src/usr.bin/svn/svn/.
> ./../../contrib/apr-util/include -I. -DHAS_ORGANIZATION_NAME -std=gnu99 
> -Qunused-arguments  -fstack-protector -Wno-pointer-sign -Wno-empty-body 
> -Wno-string-plus-int -
> Wno-unused-const-variable -Wno-tautological-compare -Wno-unused-value 
> -Wno-parentheses-equality -Wno-unused-function -Wno-enum-conversion -Wno-switch 
> -Wno-switch-enum
>   -Wno-knr-promoted-parameter -Wno-parentheses -c 
> /usr/src/usr.bin/svn/svn/../../../contrib/subversion/subversion/svn/util.c
> --- svnlite.1 ---
> sed -E 's,(^| |B|`)svn,\1svnlite,g' 
> /usr/src/usr.bin/svn/svn/../../../contrib/subversion/subversion/svn/svn.1 > 
> /usr/obj/usr/src/usr.bin/svn/svn/svnlite.1
> --- svnlite.1.gz ---
> gzip -cn svnlite.1 > svnlite.1.gz
> --- util.o ---
> /usr/src/usr.bin/svn/svn/../../../contrib/subversion/subversion/svn/util.c:416:7: error: 
> expected ')'
>        ORGANIZATION_NAME
>        ^
> ./freebsd-organization.h:1:27: note: expanded from macro 'ORGANIZATION_NAME'
> #define ORGANIZATION_NAME TundraWare Inc.
>                            ^
> /usr/src/usr.bin/svn/svn/../../../contrib/subversion/subversion/svn/util.c:414:27: 
> note: to match this '('
>    svn_stringbuf_appendcstr(default_msg, "Sponsored by:\t"
>                            ^
> 1 error generated.
> *** [util.o] Error code 1
> 
> 

It looks like you've set ORGANIZATION=TundraWare Inc. in make.conf or
the build environment.  If you include quotes it should work fine.
Depending on where you set it, you may need to escape them or use outer
single quotes to protect a set of inner double quotes, like one of:

  ORGANIZATION=\"TundraWare Inc.\"
  ORGANIZATION='"TundraWare Inc."'

-- Ian