9-STABLE nfsd(8) does not auto-tune number of threads (error in the 9.3 Release Notes!)

[Glen Barber]

On Tue, Jul 08, 2014 at 03:46:36PM -0400, Rick Macklem wrote:
> Glen Barber wrote:
> > On Tue, Jul 08, 2014 at 03:06:38PM +0200, José María Alcaide wrote:
> > > One of the 9.3-RELEASE Release Notes (userland changes) states
> > > that:
> > > 
> > > "The default number of nfsd(8) threads has been increased from 4 to
> > > (8 * N), where N is the number of CPUs as reported by sysctl -n
> > > hw.ncpu. [r262124]"
> > > 
> > > Indeed, revision r262124
> > > (http://svnweb.freebsd.org/base?view=revision&revision=262124)
> > > removes the "-n 4" option from nfs_server_flags in
> > > /etc/defaults/rc.conf.
> > > 
> > > The change is based on the premise that nfsd(8) auto-tunes the
> > > number of threads as (8 * hw.ncpu). That auto-tuning was
> > > introduced in HEAD revision r243637 of nfsd.c
> > > (http://svnweb.freebsd.org/base?view=revision&revision=243637),
> > > but it has not been MFC'd to 9-STABLE yet, so that release note
> > > *is not true*.
> > > 
> > > I think that r262124 should be reverted, also removing the release
> > > note mentioned above; or alternatively bring HEAD's nfsd.c on sync
> > > with 9-STABLE (probably a bad idea just before 9.3-RELEASE).
> > > 
> > 
> > Reverting r262124 is also not an option at this point of the release
> > cycle.
> > 
> > Rick, do you have any reservations to issuing an errata notice for
> > this
> > after the release?
> > 
> Well, I think that it will generate 4 threads without the "-n 4" just like
> it does with the "-n 4", so the only issue I see is the statement in the
> release notes isn't accurate. (It doesn't seem worth reverting r262124, since
> it doesn't really affect the outcome?)
> 
> I'd suggest just taking the statement out of the release notes.
> 

Ok, thanks.

> rick
> ps: This change wasn't my commit, but I didn't see a problem with the
>     default changing. I have fixing the nfsd(8) man page to reflect
>     this change in default on my "to do" list.
> 

Yeah, I realized it wasn't yours afterward :(

Thanks.

Glen

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-stable/attachments/20140708/b1108ca0/attachment.sig>