stable/9 r264014 problems

[Glen Barber]

On Tue, Apr 08, 2014 at 11:03:02PM -0400, Glen Barber wrote:
> On Tue, Apr 08, 2014 at 07:56:25PM -0700, Jeremy Chadwick wrote:
> > (Please keep me CC'd as I'm not subscribed to freebsd-stable@)
> > 
> > Root cause appears related to r264014:
> > 
> > http://svnweb.freebsd.org/base/stable/9/Makefile.inc1?annotate=264014
> > 
> > My src/ correlates with r264285, so it seems this issue has been
> > lingering for a week now.  Did anyone truly test this fully before
> > committing?  (Yes I read the commit message; consider me doubtful)
> > 
> 
> Of course.  But it seems 'delete-old' target did not get thoroughly
> tested.
> 
> > There is no /usr/obj/usr/src/sys/sys/param.h.  Maybe what's wanted is
> > /usr/obj/usr/src/tmp/sys/sys/param.h or
> > /usr/obj/usr/src/include/osreldate.h (both of which exit and define
> > __FreeBSD_version)?
> > 
> > There is no /usr/obj/usr/src/release, so I don't know what any of that
> > is about.
> > 
> > I can make a PR for this if asked.
> > 
> 
> Not necessary.  I need some time to test some changes, but I do see what
> is wrong.
> 

Hmm, maybe I do not see quite what is wrong.

Can you show me output of 'uname -U' and 'svn info /usr/src' ?

When I run 'delete-old' against stable/9 at r264148, I do see some unwanted
noise, but nothing nearly as intrusive as you see.

root at grind:/usr/src # make delete-old
>>> Removing old files (only deletes safe to delete libs)
awk: can't open file /usr/obj/usr/src/sys/sys/param.h
 source line number 1
"/usr/src/Makefile.inc1", line 137: warning: "awk '/^#define[[:space:]]*__FreeBSD_version/ { print $3 }'
/usr/obj/usr/src/sys/sys/param.h" returned non-zero status
>>> Old files removed
>>> Removing old directories
awk: can't open file /usr/obj/usr/src/sys/sys/param.h
 source line number 1
"/usr/src/Makefile.inc1", line 137: warning: "awk '/^#define[[:space:]]*__FreeBSD_version/ { print $3 }'
/usr/obj/usr/src/sys/sys/param.h" returned non-zero status
>>> Old directories removed
To remove old libraries run '/usr/obj/usr/src/make.amd64/make delete-old-libs'.

Glen

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-stable/attachments/20140408/6965831e/attachment.sig>