FreeBSD-9.1: machine reboots during snapshot creation, LORs found

[Konstantin Belousov]

On Fri, Jul 19, 2013 at 07:32:47AM +0200, Andre Albsmeier wrote:
> On Thu, 04-Jul-2013 at 19:25:28 +0200, Konstantin Belousov wrote:
> > Patch is to improve debugging.
> > 
> > I probably commit it after the issue is closed.  Arguments against
> > the commit is that the change imposes small performance penalty
> > due to save and restore of the %ebp (I doubt that this is measureable
> > by any means).  Also, arguably, such change should be done for all
> > functions in support.s, but bcopy() is the hot spot.
> 
> Thanks to this patch, we (you ;-) were able to track down the problem.
> So how are we going to deal with this debugging patch itself?
> My suggestion would be to #ifdef it somehow so on one hand it will
> be availabe in future (and with bcopy being used a lot probability
> is high it might help in other places), on the other hand it won't
> steal cycles during normal use.

This was already committed as r253328 in HEAD.  I dislike the #ifdef,
since the stack access is interwinned through all text, making the
function forked.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-stable/attachments/20130719/234e24b3/attachment.sig>