XHCI umass support breaks between r248085 and r252560 on 9-STABLE

[Alexandre Kovalenko]

Three different external hard drives (Seagate, Western Digital and noname USB 3.0 enclosure) refused to be recognized as the umass devices. Reverting /usr/src/sys/dev/bsd/controller to r248085, building and loading just xhci module makes drives appear again. Below are snippets from the log in both cases:

Non working:

Jul  4 14:35:17 twinhead kernel: xhci0: <XHCI (generic) USB 3.0 controller> mem 0xfddfe000-0xfddfffff irq 16 at device 0.0 on pci2
Jul  4 14:35:17 twinhead kernel: xhci0: 64 byte context size.
Jul  4 14:35:17 twinhead kernel: usbus0 on xhci0
Jul  4 14:35:17 twinhead kernel: usbus0: 5.0Gbps Super Speed USB v3.0
Jul  4 14:35:17 twinhead kernel: ugen0.1: <0x1912> at usbus0
Jul  4 14:35:17 twinhead kernel: uhub0: <0x1912 XHCI root HUB, class 9/0, rev 3.00/1.00, addr 1> on usbus0
Jul  4 14:35:17 twinhead kernel: uhub0: 8 ports with 8 removable, self powered
Jul  4 14:35:24 twinhead kernel: ugen0.2: <ASMedia> at usbus0
Jul  4 14:35:24 twinhead kernel: umass0: <ASMedia AS2105, class 0/0, rev 3.00/0.01, addr 1> on usbus0
Jul  4 14:35:29 twinhead kernel: (probe0:umass-sim0:0:0:0): INQUIRY. CDB: 12 00 00 00 24 00 
Jul  4 14:35:29 twinhead kernel: (probe0:umass-sim0:0:0:0): CAM status: CCB request completed with an error
Jul  4 14:35:29 twinhead kernel: (probe0:umass-sim0:0:0:0): Retrying command
Jul  4 14:35:30 twinhead kernel: (probe0:umass-sim0:0:0:0): INQUIRY. CDB: 12 00 00 00 24 00 
Jul  4 14:35:30 twinhead kernel: (probe0:umass-sim0:0:0:0): CAM status: CCB request completed with an error
Jul  4 14:35:30 twinhead kernel: (probe0:umass-sim0:0:0:0): Retrying command
Jul  4 14:35:35 twinhead kernel: (probe0:umass-sim0:0:0:0): INQUIRY. CDB: 12 00 00 00 24 00 
Jul  4 14:35:35 twinhead kernel: (probe0:umass-sim0:0:0:0): CAM status: CCB request completed with an error
Jul  4 14:35:35 twinhead kernel: (probe0:umass-sim0:0:0:0): Retrying command
Jul  4 14:35:36 twinhead kernel: (probe0:umass-sim0:0:0:0): INQUIRY. CDB: 12 00 00 00 24 00 
Jul  4 14:35:36 twinhead kernel: (probe0:umass-sim0:0:0:0): CAM status: CCB request completed with an error
Jul  4 14:35:36 twinhead kernel: (probe0:umass-sim0:0:0:0): Retrying command
Jul  4 14:35:41 twinhead kernel: (probe0:umass-sim0:0:0:0): INQUIRY. CDB: 12 00 00 00 24 00 
Jul  4 14:35:41 twinhead kernel: (probe0:umass-sim0:0:0:0): CAM status: CCB request completed with an error
Jul  4 14:35:41 twinhead kernel: (probe0:umass-sim0:0:0:0): Error 5, Retries exhausted

Working:

Jul  4 14:40:20 twinhead kernel: ugen0.2: <ASMedia> at usbus0 (disconnected)
Jul  4 14:40:20 twinhead kernel: umass0: at uhub0, port 2, addr 1 (disconnected)
Jul  4 14:40:27 twinhead kernel: ugen0.2: <vendor 0x174c> at usbus0
Jul  4 14:40:27 twinhead kernel: umass0: <vendor 0x174c product 0x5106, class 0/0, rev 3.00/0.01, addr 1> on usbus0
Jul  4 14:40:27 twinhead kernel: (probe0:umass-sim0:0:0:0): REPORT LUNS. CDB: a0 00 00 00 00 00 00 00 00 10 00 00 
Jul  4 14:40:27 twinhead kernel: (probe0:umass-sim0:0:0:0): CAM status: SCSI Status Error
Jul  4 14:40:27 twinhead kernel: (probe0:umass-sim0:0:0:0): SCSI status: Check Condition
Jul  4 14:40:27 twinhead kernel: (probe0:umass-sim0:0:0:0): SCSI sense: ILLEGAL REQUEST asc:20,0 (Invalid command operation code)
Jul  4 14:40:27 twinhead kernel: (probe0:umass-sim0:0:0:0): Error 22, Unretryable error
Jul  4 14:40:27 twinhead kernel: da0 at umass-sim0 bus 0 scbus4 target 0 lun 0
Jul  4 14:40:27 twinhead kernel: da0: <Hitachi HTS542520K9SA00 BBDO> Fixed Direct Access SCSI-5 device 
Jul  4 14:40:27 twinhead kernel: da0: 400.000MB/s transfers
Jul  4 14:40:27 twinhead kernel: da0: 190782MB (390721968 512 byte sectors: 255H 63S/T 24321C)
Jul  4 14:40:27 twinhead kernel: da0: quirks=0x2<NO_6_BYTE>

I can provide additional information or try  patches as necessary.

Alexandre "Sunny" Kovalenko (Олександр Коваленко)