CLANG 3.2 breaks security/pam_ssh_agent_auth on stable/9

[Kimmo Paasiala]

On Tue, Jan 29, 2013 at 9:08 PM, Mike Tancsa <mike at sentex.net> wrote:
> On 1/17/2013 4:35 PM, Kimmo Paasiala wrote:
>> On Thu, Jan 17, 2013 at 5:15 PM, Dimitry Andric <dim at freebsd.org> wrote:
>>> On 2013-01-17 14:07, Kimmo Paasiala wrote:
>>>>
>>>> On Thu, Jan 17, 2013 at 2:11 AM, Brooks Davis <brooks at freebsd.org> wrote:
>>>
>>> ...
>>>
>>> Please try the following patch, which tells configure that HAVE_STRNVIS
>>> is always false.  I think this is the easiest way, unless we really want
>>> the port to use our own strnvis.
>>
>> This will still leave the exported symbol in the plugin binary with
>> the name strnvis. What would be needed is renaming of the function to
>> something else, like pam_ssh_agent_auth_strnvis(), maybe using a macro
>>
>> #define strnvis pam_ssh_agent_auth_strnvis
>>
>> somewhere.
>>
>> I can try my hand on coming up with a fix but its going to take some
>> time, the source code of the plugin and not to mention the configure
>> script look quite hairy.
>
> Hi,
>         Just wondering if anyone ever came up with a patch / work around to this ?
>
>         ---Mike
>
>
> --

Hi,

Yes I did in fact but it's a really quick and dirty hack. I renamed
the openbsd strnvis to strnvis_local so the symbol in plugin binary
won't conflict with strnvis from libc. I'll have to see if I can clean
it up and submit a PR with a diff.

-Kimmo