CLANG 3.2 breaks security/pam_ssh_agent_auth on stable/9

[Dimitry Andric]

On 2013-01-17 14:07, Kimmo Paasiala wrote:
> On Thu, Jan 17, 2013 at 2:11 AM, Brooks Davis <brooks at freebsd.org> wrote:
...
>> NetBSD and OpenBSD use different signatures for strnvis(). :(
>> pam_ssh_agent_auth assumes that if the system has one it is the OpenBSD
>> one but ours is the NetBSD one.  The port will need to be patched to use
>> the openbsd version like it was doing or to swap the second and third
>> arguments when build on newer versions of FreeBSD.
> It turns out that security/pam_ssh_agent_auth compiles its own version
> of strnvis() when HAVE_STRNVIS is not defined. This in turn results in
> an exported dynamic strnvis symbol in the plugin binary. I guess
> that's what is breaking things when the plugin binary is loaded on
> post r245439 world.
>
> First thing that comes to my mind for a fix is renaming the local
> strnvis() to something else conditionally based on HAVE_STRNVIS.

Please try the following patch, which tells configure that HAVE_STRNVIS
is always false.  I think this is the easiest way, unless we really want
the port to use our own strnvis.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: security__pam_ssh_agent_auth-1.diff
Type: text/x-diff
Size: 439 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-stable/attachments/20130117/7fa1ce34/attachment.diff>