Problem with zfsloader on 9.2-BETA2

[J David]

On Sat, Aug 3, 2013 at 3:16 PM, Andriy Gapon <avg at freebsd.org> wrote:
> Very unusual.  Would you be able to try 9.2 zfsloader again?

Surely.

> I would like to see values of loaddev, currdev and vfs.zfs.boot.primary_pool
> loader variables (if any are set).  These can be obtained using 'show' command
> at loader prompt.

OK show loaddev

OK show currdev

OK show vfs.zfs.boot.primary_pool
2022708996989799150

> Also, output of lsdev -v.

OK lsdev -v
cd devices:
disk devices:
    disk0:   BIOS drive C:
      disk0p1: FreeBSD boot        64KB
      disk0p2: FreeBSD swap        2048MB
      disk0p3: FreeBSD ZFS         28GB
    disk1:   BIOS drive D:
      disk1p1: FreeBSD boot        64KB
      disk1p2: FreeBSD swap        2048MB
      disk1p3: FreeBSD ZFS         27GB
    disk2:   BIOS drive E:
    disk3:   BIOS drive F:
    disk4:   BIOS drive G:
    disk5:   BIOS drive H:
    disk6:   BIOS drive I:
    disk7:   BIOS drive J:
pxe devices:
zfs devices:
OK

> Also, if you are able to build custom 9.2 zfsloader, then it would be useful to
> modify the printf statement (in zfs_fmtdev(), sys/boot/zfs/zfs.c) to print
> dev->pool_guid.

This didn't produce the expected result.  Slipped it into the 9.2-RC1
build, rebuilt, installed it, but nothing changed.

In order to get it to load, we removed zfsloader, storing the 8.4
version as zfsloader-8.4 and installing the 9.2-RC1 zfsloader as
zfsloader-9.2.

Then, when the gptzfsboot can't find /boot/zfsloader, I entered
zfsloader-9.2 at the prompt.  It does the same thing, with the same
message:

ZFS: can't find pool by guid

Even though I changed the source as you suggested:


Index: zfs.c
===================================================================
--- zfs.c	(revision 253967)
+++ zfs.c	(working copy)
@@ -645,7 +645,7 @@
 	} else
 		spa = spa_find_by_guid(dev->pool_guid);
 	if (spa == NULL) {
-		printf("ZFS: can't find pool by guid\n");
+		printf("ZFS: can't find pool by guid: %llX\n", dev->pool_guid);
 		return (buf);
 	}
 	if (dev->root_guid == 0 && zfs_get_root(spa, &dev->root_guid)) {


So I can't figure out why the message didn't change.  Doing a full
buildworld buildkernel right now in case the problem is just that I
don't know how to selectively build this.

Thanks!