[patch proposal typo corrected] Re: SU+J on 9.1-RC2 ISO

[Bas Smeelen]

On 11/02/2012 06:27 PM, Adam Strohl wrote:
> On 11/3/2012 0:13, Mike Jakubik wrote:
>> You can disable SU+J after installing, though it would be nice if the
>> installer gave you a choice.
>
> This assumes that you know about this flaw, which most people do not.
>
> I didn't until I discovered it by panic-ing a perfectly fine running
> server.  Getting burned by a known bug like this shouldn't be "SOP"
> for users of FreeBSD.
>
> If anything it should be turned off by default, and people can turn it
> on if they want given the landmine it plants.  If they know how to
> turn it on they're much more likely to be aware of the issue.
>
>
Hi all

I am not sure if this is the right place, but would like to propose this 
patch
root at sys:/usr/src/usr.sbin/bsdinstall/partedit # diff -p gpart_ops.c 
gpart_ops.cnew
*** gpart_ops.c    Mon Aug  6 01:54:33 2012
--- gpart_ops.cnew    Fri Nov  2 19:02:43 2012
*************** newfs_command(const char *fstype, char *
*** 90,97 ****
               {"SU", "Softupdates",
                   "Enable softupdates (default)", 1 },
               {"SUJ", "Softupdates journaling",
!                 "Enable file system journaling (default - "
!                 "turn off for SSDs)", 1 },
               {"TRIM", "Enable SSD TRIM support",
                   "Enable TRIM support, useful on solid-state drives",
                   0 },
--- 90,97 ----
               {"SU", "Softupdates",
                   "Enable softupdates (default)", 1 },
               {"SUJ", "Softupdates journaling",
!                 "Disable file system journaling (default - "
!                 "turn on for adventurish admins)", 0 },
               {"TRIM", "Enable SSD TRIM support",
                   "Enable TRIM support, useful on solid-state drives",
                   0 },

If OK I will file a PR
Cheers
Bas



This e-mail message, including any attachment(s), is intended solely for the addressee or addressees. Any views or opinions presented herein are solely those of the author and do not necessarily represent those of OSE.

If you are not the intended recipient of this communication please return this e-mail message and the attachment(s) to the sender and delete and destroy all copies.