busdma MFC broke ipfw fwd for RELENG_6

YongHyeon PYUN pyunyh at gmail.com
Thu Sep 15 19:19:50 UTC 2011


On Fri, Sep 16, 2011 at 02:02:37AM +0700, Eugene Grosbein wrote:
> 16.09.2011 01:15, YongHyeon PYUN пишет:
> 
> > I remember re(4) in 6.x also have a couple of bus_dma(9) bugs. How
> > about applying the following revision?
> > http://svnweb.freebsd.org/base?view=revision&revision=175337
> > Not sure whether it shall apply cleanly.
> 
> It does not and there is too much differences in the code for my skills to apply manually :-)
> 
> > Alternatively try replacing BUS_DMA_ALLOCNOW to 0 in
> > bus_dma_tag_create(9).
> 
> I'm not sure I undersdand this right... Do you mean this change?

No, change BUS_DMA_ALLOCNOW used in re(4).

> This is the only place in busdma_machdep.c where BUS_DMA_ALLOCNOW is used.
> 
> --- busdma_machdep.c.orig       2011-09-16 01:56:52.000000000 +0700
> +++ busdma_machdep.c    2011-09-16 01:57:01.000000000 +0700
> @@ -284,7 +284,7 @@
>                 newtag->flags |= BUS_DMA_COULD_BOUNCE;
>  
>         if (((newtag->flags & BUS_DMA_COULD_BOUNCE) != 0) &&
> -           (flags & BUS_DMA_ALLOCNOW) != 0) {
> +           (flags & 0) != 0) {
>                 struct bounce_zone *bz;
>  
>                 /* Must bounce */
> 
> I'm going to lose control on this remote box if I apply wrong patch for re(4).
> 
> Eugene Grosbein


More information about the freebsd-stable mailing list