smartctl / mpt on 9.0-RC1

Alex Samorukov ml at os2.kiev.ua
Thu Nov 3 20:08:49 UTC 2011


Thank you,

it is really caused by MFC r225950 and smartctl way to detect sense 
length.  I decided not to add ifdefs, but change the logic.

I fixed this in SVN [1], patch in the unified diff format could be 
downladed at [2]. Please test this, and if it works fine - i will submit 
PR to the port.

[1] 
https://sourceforge.net/apps/trac/smartmontools/changeset?old_path=%2Ftrunk%2Fsmartmontools%2Fos_freebsd.cpp&old=3468&new_path=%2Ftrunk%2Fsmartmontools%2Fos_freebsd.cpp&new=3467
[2] 
https://sourceforge.net/apps/trac/smartmontools/changeset?format=diff&new=3467&old=3468&new_path=trunk%2Fsmartmontools%2Fos_freebsd.cpp&old_path=trunk%2Fsmartmontools%2Fos_freebsd.cpp



:On 11/03/2011 08:05 PM, Thomas Eberhardt wrote:
> Hi. I got the same problem. After some debugging I came up with the
> following patch:
>
> --- os_freebsd.cpp.orig	2011-10-06 18:43:44.000000000 +0200
> +++ os_freebsd.cpp	2011-10-23 11:19:31.492599837 +0200
> @@ -1044,8 +1044,13 @@
>     }
>
>     if (iop->sensep) {
> +#if CAM_VERSION<  0x16
>       memcpy(iop->sensep,&(ccb->csio.sense_data),sizeof(struct scsi_sense_data));
>       iop->resp_sense_len = sizeof(struct scsi_sense_data);
> +#else
> +    memcpy(iop->sensep,&(ccb->csio.sense_data),sizeof(struct scsi_sense_data_fixed));
> +    iop->resp_sense_len = sizeof(struct scsi_sense_data_fixed);
> +#endif
>     }
>
>     iop->scsi_status = ccb->csio.scsi_status;
>
>
>
> On 03.11.2011, at 19:52, Alex Samorukov wrote:
>
>



More information about the freebsd-stable mailing list