FreeBSD 8.1-PRERELEASE: WARNING ioctl sign-extension ioctl ffffffff8004667e

Xin LI delphij at delphij.net
Wed Jun 23 19:16:45 UTC 2010


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 2010/06/23 12:10, Jung-uk Kim wrote:
> It is still a kludge and it won't be fixed. :-(

Another thought - what about just hiding the printf under #ifdef
DIAGNOSTIC...  I don't really see any reason why we must print it out if
we truncate it every time...

Cheers,
- -- 
Xin LI <delphij at delphij.net>	http://www.delphij.net/
FreeBSD - The Power to Serve!	       Live free or die
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.15 (FreeBSD)

iQEcBAEBCAAGBQJMIl2QAAoJEATO+BI/yjfBpz0IAM88YOx5CVoYRCEW8EwCaW+N
5Ugks9hCvbsJgU2yLxeg5hGal0wOHKONLxaq9pXvQFybgRT9SLmna2FJLTJ6XYTu
pjtjeby40mpwRTwU5rZgJ//aYgHW48kK9N/CoE63zKycYQbjLFGnZmXbel9itZzL
Xnpj9kc0zlpqtk6yZd4XA+m90VrIgnMKmxeP0A5OzuWJKUBmvciqSMYEBQ0pkP03
sSiN5QIzW/gRMgYSJEsTGz5+q10ZDf0NOecuhOujLphWLzWxkq6UOqRi3JXvFaqo
ajRDpGEG65r2IDd8qo4y50U0FGeHmysTFUPU3aAOzjb10LbNbmT6zX+3G1rSMFY=
=A2pe
-----END PGP SIGNATURE-----
-------------- next part --------------
Index: sys/kern/sys_generic.c
===================================================================
--- sys/kern/sys_generic.c	(revision 209472)
+++ sys/kern/sys_generic.c	(working copy)
@@ -628,9 +628,11 @@
 	caddr_t data;
 
 	if (uap->com > 0xffffffff) {
+#ifdef DIAGNOSTIC
 		printf(
 		    "WARNING pid %d (%s): ioctl sign-extension ioctl %lx\n",
 		    td->td_proc->p_pid, td->td_name, uap->com);
+#endif
 		uap->com &= 0xffffffff;
 	}
 	com = uap->com;


More information about the freebsd-stable mailing list