New ZFSv28 patchset for 8-STABLE: ARRRGG HELP !!

[Jean-Yves Avenard]

Hi

On Tuesday, 28 December 2010, Freddie Cash <fjwcash at gmail.com> wrote:
> On Sun, Dec 26, 2010 at 4:43 PM, Jean-Yves Avenard <jyavenard at gmail.com> wrote:
>> On 27 December 2010 09:55, Jean-Yves Avenard <jyavenard at gmail.com> wrote:
>>> Hi there.
>>>
>>> I used stable-8-zfsv28-20101223-nopython.patch.xz from
>>> http://people.freebsd.org/~mm/patches/zfs/v28/
>>
>> I did the following:
>>
>> # zpool status
>>  pool: pool
>>  state: ONLINE
>>  scan: none requested
>> config:
>>
>>        NAME            STATE     READ WRITE CKSUM
>>        pool            ONLINE       0     0     0
>>          raidz1-0      ONLINE       0     0     0
>>            ada2        ONLINE       0     0     0
>>            ada3        ONLINE       0     0     0
>>            ada4        ONLINE       0     0     0
>>            ada5        ONLINE       0     0     0
>>            ada6        ONLINE       0     0     0
>>            ada7        ONLINE       0     0     0
>>        cache
>>          label/zcache  ONLINE       0     0     0
>>
>> errors: No known data errors
>>
>> so far so good
>>
>> [root at server4 /pool/home/jeanyves_avenard]# zpool add pool log
>> /dev/label/zil [root at server4 /pool/home/jeanyves_avenard]# zpool
>> status
>>  pool: pool
>>  state: ONLINE
>>  scan: none requested
>> config:
>>
>>        NAME            STATE     READ WRITE CKSUM
>>        pool            ONLINE       0     0     0
>>          raidz1-0      ONLINE       0     0     0
>>            ada2        ONLINE       0     0     0
>>            ada3        ONLINE       0     0     0
>>            ada4        ONLINE       0     0     0
>>            ada5        ONLINE       0     0     0
>>            ada6        ONLINE       0     0     0
>>            ada7        ONLINE       0     0     0
>>        logs
>>          label/zil     ONLINE       0     0     0
>>        cache
>>          label/zcache  ONLINE       0     0     0
>>
>> errors: No known data errors
>>
>> so far so good:
>>
>> # zpool remove pool logs label/zil
>> cannot remove logs: no such device in pool
>
> Is that a typo, or the actual command you used?  You have an extra "s"
> in there.  Should be "log" and not "logs".  However, I don't think
> that command is correct either.
>
> I believe you want to use the "detach" command, not "remove".

> # zpool detach pool label/zil
>
> --
> Freddie Cash
> fjwcash at gmail.com
>

It was a typo, it should have been log (according to sun's doc). As it
was showing "logs" in the status I typed this.
According to sun, it zpool remove pool cache/log

A typo should have never resulted in what happened, showing an error
for sure; but zpool hanging and kernel panic?