backporting dummynet's q_time change ? (svn 184414)
Luigi Rizzo
rizzo at iet.unipi.it
Fri Jan 23 02:15:50 PST 2009
On Fri, Jan 23, 2009 at 12:44:20PM +0300, Oleg Bulyzhin wrote:
> On Fri, Jan 23, 2009 at 10:23:12AM +0100, Luigi Rizzo wrote:
>
> > this is also in RELENG_7 but i am not sure whether this workaround
> > has any drawback e.g., when curr_time passes a 32-bit boundary
> > there seems to be an incorrect setting of q->numbytes
>
> Workaround is fine in average. It may fail for:
> 1) _very_ idle flow (more than 2^32 ticks) while calculating q->avg
> 2) any flow once per 2^32 ticks
> then q_time will be updated and things will be ok again.
understand - my question is whether there is strong objection
in applying the real fix (the one in HEAD) rather than this
workaround.
In my opinion the MFC is quite safe as I explained.
cheers
luigi
More information about the freebsd-stable
mailing list