FreeBSD 7.1 Breaks re and rl Network Interface Drivers

[Pyun YongHyeon]

On Mon, Jan 19, 2009 at 06:33:46PM -0500, Jung-uk Kim wrote:
 > On Monday 19 January 2009 04:33 pm, Jung-uk Kim wrote:
 > > I found something interesting.  I have another RTL8169SC that works
 > > perfectly fine without the patch.  The hardware revision is
 > > 0x18000000.  After reading Linux driver (drivers/net/r8169c), I
 > > realised they use different masks for hardware revisions.  With
 > > their logic, non-working chip seems to be 0x98000000 (8110SCe)
 > > while working chip seems to be 0x18000000 (8110SCd) with
 > > 0xfc800000. FYI...
 > 
 > Now armed with the information, I made it work without reverting 
 > memory mapped I/O. :-)
 > 
 > http://people.freebsd.org/~jkim/re/re.current2.diff
 > http://people.freebsd.org/~jkim/re/re.stable2.diff
 > 

I like the patch. Since only RTL8169 family uses mask 0xfc800000
it would be even better we can limit checking scope for RTL8169SC
by comparing PCI device id. I don't know what other side effect
would happen if the mask 0xfc800000 would be used on 8101/8168
controllers.
If the patch works on RTL8169SC would you commit the patch?
I'd like to see multiple commits separated by each enhancements
as the patch contains several fixes which are not directly related
with the issue.

-- 
Regards,
Pyun YongHyeon