Failure during GENERIC (i386) kernel build at r200721

[Andriy Gapon]

on 19/12/2009 15:35 David Wolfskill said the following:
> Attempted clean kernel build, running
> 
> FreeBSD freebeast.catwhisker.org 7.2-STABLE FreeBSD 7.2-STABLE #11 r200664: Fri Dec 18 05:18:46 PST 2009     root at freebeast.catwhisker.org:/common/S2/obj/usr/src/sys/GENERIC  i386
> 
> [Immediately following a "make buldworld"...]
>>>> Kernel build for GENERIC started on Sat Dec 19 05:05:56 PST 2009
> ...
>>>> stage 3.2: building everything
> ...
> cc -c -O -pipe  -std=c99 -g -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -Wundef -Wno-pointer-sign -fformat-extensions -nostdinc  -I. -I/usr/src/sys -I/usr/src/sys/contrib/altq -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000  -mno-align-long-strings -mpreferred-stack-boundary=2  -mno-mmx -mno-3dnow -mno-sse -mno-sse2 -mno-sse3 -ffreestanding -Werror  /usr/src/sys/i386/i386/machdep.c
> cc -c -O -pipe  -std=c99 -g -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -Wundef -Wno-pointer-sign -fformat-extensions -nostdinc  -I. -I/usr/src/sys -I/usr/src/sys/contrib/altq -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000  -mno-align-long-strings -mpreferred-stack-boundary=2  -mno-mmx -mno-3dnow -mno-sse -mno-sse2 -mno-sse3 -ffreestanding -Werror  /usr/src/sys/i386/i386/mca.c
> cc1: warnings being treated as errors
> /usr/src/sys/i386/i386/mca.c: In function 'mca_init':
> /usr/src/sys/i386/i386/mca.c:510: warning: implicit declaration of function 'CPUID_TO_FAMILY'
> /usr/src/sys/i386/i386/mca.c:510: warning: nested extern declaration of 'CPUID_TO_FAMILY'
> /usr/src/sys/i386/i386/mca.c:511: warning: implicit declaration of function 'CPUID_TO_MODEL'
> /usr/src/sys/i386/i386/mca.c:511: warning: nested extern declaration of 'CPUID_TO_MODEL'
> *** Error code 1
> 
> Stop in /common/S2/obj/usr/src/sys/GENERIC.
> *** Error code 1
> 
> Stop in /usr/src.
> *** Error code 1
> 
> Stop in /usr/src.
> 
> 
> As a reality check:
> 
> freebeast(7.2-S)[8] cd /usr/src
> freebeast(7.2-S)[9] grep -wnr CPUID_TO_FAMILY .
> ./sys/i386/i386/.svn/text-base/mca.c.svn-base:510:                             if (i == 0 && CPUID_TO_FAMILY(cpu_id) == 0x6
> ./sys/i386/i386/.svn/text-base/mca.c.svn-base:515:                             if (i == 4 && CPUID_TO_FAMILY(cpu_id) >= 0xf)
> ./sys/i386/i386/mca.c:510:                              if (i == 0 && CPUID_TO_FAMILY(cpu_id) == 0x6
> ./sys/i386/i386/mca.c:515:                              if (i == 4 && CPUID_TO_FAMILY(cpu_id) >= 0xf)
> ./sys/amd64/amd64/.svn/text-base/mca.c.svn-base:510:                           if (i == 0 && CPUID_TO_FAMILY(cpu_id) == 0x6
> ./sys/amd64/amd64/.svn/text-base/mca.c.svn-base:515:                           if (i == 4 && CPUID_TO_FAMILY(cpu_id) >= 0xf)
> ./sys/amd64/amd64/mca.c:510:                            if (i == 0 && CPUID_TO_FAMILY(cpu_id) == 0x6
> ./sys/amd64/amd64/mca.c:515:                            if (i == 4 && CPUID_TO_FAMILY(cpu_id) >= 0xf)
> freebeast(7.2-S)[10] 
> 
> [cut/pasted, so whitespace may not match].
> 
> Was a definition or two overlooked?

My apologies, this is a result of me not being attentive and taking shortcuts
during MFC.  The breakage should be fixed as of r200742.

-- 
Andriy Gapon