running mksnap_ffs

[Kris Kennaway]

On Tue, Jan 16, 2007 at 10:13:57AM -0800, Doug Ambrisko wrote:

> FWIW, with this patch I find making snap-shots a lot more reliable:
> 
> --- sys/ufs/ffs/ffs_snapshot.c.orig	Wed Mar 22 09:42:31 2006
> +++ sys/ufs/ffs/ffs_snapshot.c	Mon Nov 20 14:59:13 2006
> @@ -282,6 +282,8 @@ restart:
>  		if (error)
>  			goto out;
>  		bawrite(nbp);
> +		if (cg % 10 == 0)
> +			ffs_syncvnode(vp, MNT_WAIT);
>  	}
>  	/*
>  	 * Copy all the cylinder group maps. Although the
> @@ -303,6 +305,8 @@ restart:
>  			goto out;
>  		error = cgaccount(cg, vp, nbp, 1);
>  		bawrite(nbp);
> +		if (cg % 10 == 0)
> +			ffs_syncvnode(vp, MNT_WAIT);
>  		if (error)
>  			goto out;
>  	}
> 
> or things can get wedged.  We have some other patches as well that might
> be required.  As a hack on a local server we have been using snap shots
> to do a "hot" back-up of a data base each morning.  This is based on
> 6.x.

What do you mean by "get wedged"?  Are you seeing a deadlock, and if
so then what are the details?  When you say 6.x, do you mean
up-to-date RELENG_6?  There were various snapshot deadlock fixes
committed over the past year including some in the past few months.

Kris
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-stable/attachments/20070116/c73b73c9/attachment.pgp