[PATCH] option to re-enable aggressive ATA probing (was: 5.3 -> 5.4 breaks ATA (Intel ICH2))

[Tim Howe]

Tim Howe <tim.howe at celebrityresorts.com> writes:

> ata0-master: stat=0xd0 err=0xd0 lsb=0xd0 msb=0xd0

This turned out to be the key.

Version 1.51 of ata-lowlevel.c added a check for stat0/1, err, lsb, and
msb being identical.  If they are, it aborts the probe.  The attached
patch creates an option ATA_AGGRESSIVE_PROBE which disables this for the
old aggressive behavior (which may wait up to the full 31 seconds).

I also took the liberty of reworking the still-busy check from 3
equality tests to 2 bitmask tests.  It seems simpler to my eye with
identical results, but if I missed something or the other style was
preferred please let me know.

The patch is against 5-STABLE because that's what I have.

-- 
Tim Howe
Software Engineer
Celebrity Resorts, Inc.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ata_aggressive_probe.patch
Type: text/x-patch
Size: 2375 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-stable/attachments/20050927/f8a69671/ata_aggressive_probe.bin