make buildworld for RELENG_5 failing on RELENG_5_3 in /usr/src/usr.sbin/syslogd, _PATH_LOG_PRIV not defined

[Steve Hodgson]

On Sunday 16 January 2005 17:37, Kris Kennaway wrote:
> On Sun, Jan 16, 2005 at 02:22:05PM +0000, Steve Hodgson wrote:
> > I'm getting the following error on a RELENG_5_3 box when trying to
> > compile the RELENG_5 sources. I've been cvsupping now for about a week
> > and continuing to get the same error when we get to syslogd.
> >
> > /usr/src/usr.sbin/syslogd/syslogd.c:141: error: `_PATH_LOG_PRIV'
> > undeclared here (not in a function)
> > /usr/src/usr.sbin/syslogd/syslogd.c:141: error: initializer element is
> > not constant
> > /usr/src/usr.sbin/syslogd/syslogd.c:141: error: (near initialization for
> > `funix_secure.name')
> > /usr/src/usr.sbin/syslogd/syslogd.c:142: error: initializer element is
> > not constant
> > /usr/src/usr.sbin/syslogd/syslogd.c:142: error: (near initialization for
> > `funix_secure.next')
> >
> > If I apply the following patch then buildworld continues to completion.
> > Note the same error appears in libc and the patch fixes that as well.
> > Judging by the build logs and lack of others complaining I'm the only one
> > with this problem, so clearly this isn't the correct solution, but it
> > works for me.
> >
> > --- /usr/src/usr.sbin/syslogd/syslogd.c.old       Sun Jan 16 12:16:25
> > 2005 +++ /usr/src/usr.sbin/syslogd/syslogd.c   Sun Jan 16 12:17:53 2005
> > @@ -74,6 +74,7 @@
> >  #define DEFSPRI                (LOG_KERN|LOG_CRIT)
> >  #define TIMERINTVL     30              /* interval for checking flush,
> > mark */
> >  #define TTYMSGTIME     1               /* timeout passed to ttymsg */
> > +#define       _PATH_LOG_PRIV  "/var/run/logpriv"
> >
> >  #include <sys/param.h>
> >  #include <sys/ioctl.h>
> > --- /usr/src/lib/libc/gen/syslog.c.old    Sun Jan 16 14:12:49 2005
> > +++ /usr/src/lib/libc/gen/syslog.c        Sun Jan 16 13:03:41 2005
> > @@ -60,6 +60,8 @@
> >
> >  #include "libc_private.h"
> >
> > +#define       _PATH_LOG_PRIV  "/var/run/logpriv"
> > +
> >  static int     LogFile = -1;           /* fd for log */
> >  static int     status;                 /* connection status */
> >  static int     opened;                 /* have done openlog() */
> >
> > Any ideas on what could be wrong with my system? FYI In general I use
> > ccache but i've disabled it for this run, by editing out the commands
> > in /etc/make.conf.
>
> Try
>
> make cleandir
> make cleandir
> make buildworld
>
> Kris

This fixed the first error in usr.sbin/syslogd/syslogd.c, but the error in 
lib/libc/gen/syslog.c still occured, same (half) patch fixes it. Unless 
anyone has any other ideas I guess I'll continue reattempting this. Are there 
any objections to doing a make installworld/installkernel on the results 
after applying my patches - will that bork my system, could it help in 
anyway?