Merging phk's filedesc cleanup and lock pushdown.

[Emanuel Strobl]

Am Sonntag, 27. Februar 2005 03:51 schrieb Jeff Roberson:
> Fixed the build and merged this.  Any stable users who can should test
> this.  I'm very confident in it, but more eyes and users are better.

I haven't really understood what filedesc code is and does, but accidentaly I 
have several boxes here which will act as a fileserver at some point but 
needn't to be stable for the next two weeks.
What exactly should I test?

-Harry

>
> Thanks,
> Jeff
>
> On Thu, 24 Feb 2005, Francois Tigeot wrote:
> > On Thu, Feb 24, 2005 at 03:18:49AM -0500, Jeff Roberson wrote:
> > > I am going to MFC phk's filedesc related work in the next few days. 
> > > This is required if I am ever to merge the vfs smp changes.  I have a
> > > patch available at:
> > >
> > > http://www.chesapeake.net/~jroberson/fdesc.patch
> > >
> > > I'd appreciate it if anyone who can would test this.  It has been
> > > running on current for 3-4 months, depending on the bit, but there's
> > > always a chance of a botched merge.
> >
> > World doesn't build with this patch:
> >
> > cc -O -pipe -Wsystem-headers -Werror -Wall -Wno-format-y2k -W
> > -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type
> > -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wcast-align
> > -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls -c
> > /usr/src/usr.bin/fstat/fstat.c
> > /usr/src/usr.bin/fstat/fstat.c: In function `dofiles':
> > /usr/src/usr.bin/fstat/fstat.c:325: error: storage size of 'filed0' isn't
> > known /usr/src/usr.bin/fstat/fstat.c:363: error: `NDFILE' undeclared
> > (first use in this function) /usr/src/usr.bin/fstat/fstat.c:363: error:
> > (Each undeclared identifier is reported only once
> > /usr/src/usr.bin/fstat/fstat.c:363: error: for each function it appears
> > in.) /usr/src/usr.bin/fstat/fstat.c:325: warning: unused variable
> > `filed0' *** Error code 1
> >
> > Stop in /usr/src/usr.bin/fstat.
> > *** Error code 1
> >
> > Stop in /usr/src/usr.bin.
> > *** Error code 1
> >
> > Stop in /usr/src.
> > *** Error code 1
> >
> > Stop in /usr/src.
> > *** Error code 1
> >
> > Stop in /usr/src.
> > nice make buildworld  1209,00s user 251,75s system 78% cpu 31:04,65 total
> >
> > This machine is an amd64 5.3-STABLE host. The same sources build nicely
> > without the patch.
> >
> > --
> > Francois Tigeot
>
> _______________________________________________
> freebsd-stable at freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-stable
> To unsubscribe, send any mail to "freebsd-stable-unsubscribe at freebsd.org"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-stable/attachments/20050228/bcc7a697/attachment-0001.bin