patch again: cvs and read-only repositories

[Barry Bouwsma]

[drop the above ipv6-only address that only sometimes works from the
 recipients and I'll catch up later from the archives, thanks]


Hi!

I've got the following patch in my FreeBSD4 source.  Perhaps it
is a candidate to be merged into RELENG_4?  Pretty please?

It somehow fixes the case which is somehow b0rken when one
tries to update from a read-only repository (whether de-facto
or as specified on the command line, I do no remember, sorry)


--- tag.c-ORIG	Tue Jan 21 23:26:46 2003
+++ tag.c	Tue May 11 16:49:53 2004
@@ -1300,7 +1300,7 @@
 	/* The tags is valid but not mentioned in val-tags.  Add it.  */
 	datum value;
 
-	if (noexec || nowrite)
+	if (noexec || nowrite || readonlyfs)
 	{
 	    if (db != NULL)
 		dbm_close (db);



If I could remember how to reproduce the bug, I'd say so,
but as I recall, it has to do with a combination of a read-
only-mounted repository and/or specifying the -R flag to the
client.  Without this patch, the server tries to write to
the read-only repository and fails.

This patch is probably based on something seen in one or
more of the other BSDen.


thanks
barry bouwsma