Fix make release for 4-STABLE

[Ruslan Ermilov]

On Mon, Jan 19, 2004 at 09:47:45AM +0000, Colin Percival wrote:
> At 09:28 19/01/2004, Ruslan Ermilov wrote:
> >Maybe it's time for drivers.flp to appear on RELENG_4?  If someone
> >could MFC the support to sysinstall, I could help with release/
> >bits.
> 
>   I've already mentioned this to re@, but if there's a real need
> for space-saving, using NetBSD's makefs (ports/sysutils/makefs)
> 
Cool!  At a glance it looks like what we need to fully support
cross-arch releases, as it supports different byte-ordering.

It could also be used to get us closer to "fixing" release/ to not
require "root" privileges -- it could be a very useful feature for
developers with non-root access on fast machine.  ;)

> saves about 23k on the mfsroot floppy.
> 
I wonder if this 23k difference is on 5-CURRENT or 4-STABLE, or both?
If it is on 5-CURRENT only, does the following patch for FreeBSD's
newfs(8) make any difference:

%%%
Index: mkfs.c
===================================================================
RCS file: /home/ncvs/src/sbin/newfs/mkfs.c,v
retrieving revision 1.83
diff -u -r1.83 mkfs.c
--- mkfs.c	27 Nov 2003 01:19:23 -0000	1.83
+++ mkfs.c	28 Nov 2003 09:33:11 -0000
@@ -324,7 +324,7 @@
 	for ( ; sblock.fs_fpg < maxblkspercg; sblock.fs_fpg += sblock.fs_frag) {
 		sblock.fs_ipg = roundup(howmany(sblock.fs_fpg, fragsperinode),
 		    INOPB(&sblock));
-		if (sblock.fs_size / sblock.fs_fpg < MINCYLGRPS)
+		if (sblock.fs_size / sblock.fs_fpg < (Oflag == 2 ? MINCYLGRPS : 1))
 			break;
 		if (CGSIZE(&sblock) < (unsigned long)sblock.fs_bsize)
 			continue;
%%%

If you don't bite me, I will try it myself.  ;)

Also, it would be nice to backport it to FreeBSD.  And I suspect
it doesn't work with UFS2, does it?  (We don't need it for releases
presently, but anyway.)


Cheers,
-- 
Ruslan Ermilov
FreeBSD committer
ru at FreeBSD.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-stable/attachments/20040119/db276307/attachment.bin