[PATCH] fix OF_finddevice return value checks on sparc64
Marius Strobl
marius at alchemy.franken.de
Fri Dec 2 15:58:10 UTC 2011
On Fri, Dec 02, 2011 at 09:06:42PM +0530, Jayachandran C. wrote:
> On Fri, Dec 2, 2011 at 7:05 PM, Jayachandran C. <jchandra at freebsd.org> wrote:
> > While going thru the OF_finddevice usage in kernel (to fix up the FDT
> > interface) I noticed that ?a few calls made to OF_finddevice in
> > sparc64 does not check the return value correctly.
> >
> > The error return is -1 not 0, and since the value is unsigned,
> > checking it for '< 0' does not work either. ?The attached patch fixes
> > this.
>
> I had not planned to commit this yet, but it has gone in with the
> related changes in r228201. Let me know if there are any objections -
> I can revert or check in further changes if needed.
>
It's okay. It would be nice if you could MFC these changes down to
stable/8 once stable/9 is open again.
Marius
More information about the freebsd-sparc64
mailing list