xorg-server anyone?

Marius Strobl marius at alchemy.franken.de
Sat Sep 11 17:43:56 PDT 2004

On Sat, Sep 11, 2004 at 09:16:44PM +0200, Dejan Lesjak wrote:
> On Saturday 11 of September 2004 20:00, Marius Strobl wrote:
> > On Fri, Sep 10, 2004 at 12:27:51PM +0200, Dejan Lesjak wrote:
> > > Does switching between those two result in any difference?
> >
> > No. With an unchanged xorg-server-6.7.0_7 Sun keyboards work with
> > neither of the two keyboard drivers under FreeBSD. With my patch for
> > f86Events.c the old one works but the new one still doesn't (sort of
> > expected from the code). Ok, I now completely don't understand why
> > the old driver did work in XFree, i.e. why the old patch for
> > f86Events.c was sufficient.
> Ah, I see now. The check for __linux__ was added to checks for __sparc__ in 
> between xfree 4.3 and xfree 4.4/xorg 6.7. See
> http://cvsweb.xfree86.org/cvsweb/xc/programs/Xserver/hw/xfree86/common/xf86Events.c.diff?r1=3.146%3Axf-4_3_0&tr1=1.1&r2=3.160%3Axf-4_4_0&tr2=3.163&diff_format=h
> (apologies for the long line).

Yes, but this alone doesn't explain why 4.3 worked. What totally confused
me was the piece of code that the old patch for f86Events.c put under a
#ifndef __sparc64__ (revision 3.156 in XFree). I now see what I missed,
in revision 3.147 this was moved inside the code that's skipped if the
keyboard is a Sun keyboard (and in case the code that's now under the
#if defined(__sparc__) && defined(__linux__) is compiled in). So my
patch was right and additionally the #ifndef __sparc64__ added in 3.156
can be removed again.
Thanks for your help!


More information about the freebsd-sparc64 mailing list