TCP/UDP cksum offload on hme(4)

Pyun YongHyeon yongari at kt-is.co.kr
Fri Jun 18 03:23:27 GMT 2004


On Fri, Jun 18, 2004 at 03:20:45AM +0200, Thomas Moestl wrote:
...
 > 
 > Just one further remark:
 > 
 > > +		if ((ifp->if_flags & IFF_LINK0) != 0)
 > > +			hme_csum_features |= CSUM_UDP;
 > > +		else
 > > +			hme_csum_features &= ~CSUM_UDP;
 > 
 > Maybe if_hwassist should be changed accordingly in this case, too. It
Yes, it needs if_hwassist modification too.

 > might be a bit counter-intuitive to need to do an extra SIOCSIFCAP
 > before this takes effect.
 > 
 > 
 > Thanks for your changes! Since people have reported that this patch
 > works well on PCI hmes, I am planning to commit it soon.
 > 
Great! Thank you very much.

Regards,
Pyun YongHyeon
-- 
Pyun YongHyeon <http://www.kr.freebsd.org/~yongari>


More information about the freebsd-sparc64 mailing list