ifconfig(8) mediaopt bug and temporary fix
yongari at kt-is.co.kr
Thu Aug 5 20:41:21 PDT 2004
On Fri, Aug 06, 2004 at 02:15:55AM +0200, Sten Spans wrote:
> On Wed, 4 Aug 2004, Pyun YongHyeon wrote:
> > On Sat, Jul 31, 2004 at 03:11:32PM +0900, To sparc64 at freebsd.org wrote:
> > Here is better patch. This should fix the two bugs of ifconfig(8)
> > on big-endian machines.
> > bug #1
> > When mediaopt full-duplex was set, global variable ifr.ifr_media
> > is set to selected media option. Therefore the next reference to
> > "ifr.ifr_addr.sa_family" is wrong since the value was overwritten
> > by selected media option.
> > bug #2
> > According to bug #1, "ifr.ifr_addr.sa_family" now has the value
> > AF_APPLETALK. So checkatrange() is called and "addreq.ifra_addr"
> > is modified. Now if ifconfig(8) has a new address to set, it
> > incorrectly use the corrupted "addreq". This yield bind(2)
> > error(EADDRNOTAVAIL) for assigned IP address.
> Cool. Let's hope this gets committed soon.
> This bug was a big pita when you have al your
> cisco's set to 100/fd.
> Thanks for the debugging.
I'll commit it monday after receiving approval of mentors.
> Sten Spans
> "There is a crack in everything, that's how the light gets in."
> Leonard Cohen - Anthem
Pyun YongHyeon <http://www.kr.freebsd.org/~yongari>
More information about the freebsd-sparc64