PCI bus numbering and orphaned devices

Justin T. Gibbs gibbs at scsiguy.com
Wed Jun 11 14:53:28 PDT 2003


> : > I'm thinking that the loop should be more like:
> : >
> : > 		pcifunchigh = 0;
> : > 		f = 0;
> : > 		hdrtype	= REG(PCIR_HEADERTYPE, 1);
> : > 		if (hdrtype & 0x7f > 2)
> : > 			continue;
> :
> : My only complaint about this is that if no device is present in the
> : slot, won't you just get all bits set in whatever you read?  If so,
> : the headertype check should be better bounded.
>
> hdrtype would be 0xff.  0xff & 0x7f is 0x7f, which is greater than 2.

Sorry.  Read the test backwards.

--
Justin



More information about the freebsd-sparc64 mailing list