FreeBSD Security Advisory FreeBSD-SA-16:31.libarchive

[Gleb Smirnoff]

On Tue, Oct 11, 2016 at 12:46:25AM +0300, George L. Yermulnik wrote:
G> Hello!
G> 
G> On Tue, 11 Oct 2016 at 00:37:43 (+0300), George L. Yermulnik wrote:
G> 
G> > > https://security.FreeBSD.org/patches/SA-16:31/libarchive-10.1.patch
G> > > https://security.FreeBSD.org/patches/SA-16:31/libarchive-10.2.patch
G> > > https://security.FreeBSD.org/patches/SA-16:31/libarchive-10.3.patch
G> 
G> > Thanx. I found that already, but Security Advisory is incorrect and that's the point.
G> > Anyway libarchive-10.3.patch generated on my 10.3 box a bunch of rejections,
G> > so I had to checkout contrib/libarchive/libarchive/ and lib/libarchive/tests/ from repository
G> > to be able to rebuild world.
G> 
G> Though I'm not able:
G> [--- cut ---]
G> --- archive_read_disk_posix.So ---
G> cc  -fpic -DPIC -DHAVE_ICONV=1 -DHAVE_ICONV_H=1 -DICONV_CONST= -O2 -pipe   -DHAVE_BZLIB_H=1 -DHAVE_L
G> IBLZMA=1 -DHAVE_LZMA_H=1 -DPLATFORM_CONFIG_H=\"/usr/src/lib/libarchive/config_freebsd.h\" -I/usr/obj
G> /usr/src/lib/libarchive -DWITH_OPENSSL -std=gnu99 -Qunused-arguments  -fstack-protector -Wsystem-hea
G> ders -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes
G>  -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wch
G> ar-subscripts -Winline -Wnested-externs -Wredundant-decls -Wold-style-definition -Wmissing-variable-
G> declarations -Wno-pointer-sign -Wno-empty-body -Wno-string-plus-int -Wno-unused-const-variable  -c /
G> usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_read_disk_posix.c -o archive_read
G> _disk_posix.So
G> /usr/src/lib/libarchive/../../contrib/libarchive/libarchive/archive_read_disk_posix.c:1577:37: error
G> : incompatible pointer types passing 'struct vfsconf *' to parameter of type 'struct xvfsconf *' [-W
G> error,-Wincompatible-pointer-types]
G>         r = getvfsbyname(sfs.f_fstypename, &vfc);
G>                                            ^~~~
G> /usr/obj/usr/src/tmp/usr/include/sys/mount.h:947:49: note: passing argument to parameter here
G> int     getvfsbyname(const char *, struct xvfsconf *);
G>                                                     ^
G> 1 error generated.
G> *** [archive_read_disk_posix.So] Error code 1
G> [--- cut ---]
G> 
G> FreeBSD 10.3-STABLE i386

If it is a 10.3-STABLE system, you should just 'svn up' and rebuild, because patch
is already included into the stable/10 branch.

The patches are for those who run releases.

-- 
Totus tuus, Glebius.