Collecting entropy from device_attach() times.

Pawel Jakub Dawidek pjd at FreeBSD.org
Sat Sep 22 09:18:49 UTC 2012


On Wed, Sep 19, 2012 at 07:28:36PM +0100, RW wrote:
> On Tue, 18 Sep 2012 23:14:22 +0200
> Pawel Jakub Dawidek wrote:
> 
> > Hi.
> > 
> 
> > The patch is here:
> > 
> > 	http://people.freebsd.org/~pjd/patches/harvest_device_attach.patch
> > 
> > Comments?
> > 
> 
> +	attachtime = get_cyclecount() - attachtime;
> 
> the above line is redundant since random_harvest() already contains a
> call to get_cyclecount().

Agreed, although in more recent patch I need total time, so I can
calculate how many bits it has, so I can estimate how much entropy there
is.

-- 
Pawel Jakub Dawidek                       http://www.wheelsystems.com
FreeBSD committer                         http://www.FreeBSD.org
Am I Evil? Yes, I Am!                     http://tupytaj.pl
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-security/attachments/20120922/a87315e7/attachment.pgp


More information about the freebsd-security mailing list