Help needed: net/rubygem-grpc

Steve Wills steve at mouf.net
Fri Jun 30 14:53:56 UTC 2017


Hi,

On 06/30/2017 06:05, Vanilla Hsu wrote:
> Hi:
> 
> I update devel/grpc to 1.4.1, and change boringssl's url to official one.
> 
> please try it again, thanks.
> 

Thanks!

We can test rubygem-grpc 1.4.1, but as long as devel/grpc is using the
bundled boringssl instead of the one from the security/boringssl port,
rubygem-grpc might as well use it's bundled copy of boringssl.

I was really hoping to avoid that as I really think bundling libs is a
bad idea in general and not something we should do. That's why I created
the boringssl port.

Would you mind telling me why you didn't want to take that part of the
change to grpc? I don't mean to sound critical, of course. I may even
decide I agree with you, but I can't until I know the reasoning. :)

Also, for the record, the boringssl port has potential to cause some
issues. Mathieu has agreed to look into fixing them. Copying him so he
can reply if his changes to boringssl require changes to the versions of
grpc and rubygem-grpc ports that link against the shared boringssl.

Steve

> 2017-06-30 0:11 GMT+08:00 Steve Wills <steve at mouf.net
> <mailto:steve at mouf.net>>:
> 
>     Hi,
> 
>     On 06/28/2017 14:08, Matthias Fechner wrote:
>     > Thanks Steve,
>     >
>     > I already added it into our repository we work with:
>     > http://gitlab.toco-domains.de/FreeBSD/GitLab/commits/9.1
>     <http://gitlab.toco-domains.de/FreeBSD/GitLab/commits/9.1>
>     >
>     > I hope that is ok for you?
>     > My poudiere is just building and I think it will take the full night:
>     > https://pkg.fechner.net/index.html
>     <https://pkg.fechner.net/index.html>
>     >
>     > I will try to do some tests (at least give the build a try). As I
>     do not have any experience with ruby, I do not really have an idea
>     how to test it.
>     >
> 
>     That's not going to work as is, see my previous message.
> 
>     I have committed a port for boringssl and patched devel/grpc to use it
>     and updated the rubygem-grpc patch. See attached (as always, let me know
>     if it doesn't come through).
> 
>     Note this will make boringssl a runtime dep of GitLab (via rubygem-grpc
>     via grpc). This lets rubygem-grpc pass it's tests, except for 1, which
>     seems like just a test which needs updating.
> 
>     If you want to run the tests, copy these files/directories:
> 
>     Gemfile
>     Rakefile
>     src/proto
>     src/ruby/.rubocop.yml
>     src/ruby/.rubocop_todo.yml
> 
>     from the devel/grpc WRKSRC to the corresponding location in the
>     rubygem-grpc WRKSRC. Then install rubygem-bundler, run "bundle install"
>     and finally run "rake" to actually execute the tests and see results.
>     (Bundler will install a bunch of gems outside pkg, so you may want to do
>     this in a throwaway jail, such as in poudriere testport -i).
> 
>     Vanilla, could you commit the devel/grpc parts of the attached patch, or
>     approve me committing it?
> 
>     I think it's better to create a separate port for boringssl and use it
>     than to have both devel/grpc and net/rubygem-grpc bundle it. I know
>     boringssl isn't meant to be used this way, based on the docs. But I
>     think it's better to avoid bundling it, because bundling allows to
>     possibly use different versions in different ports and also means more
>     work to update it.
> 
>     Also, the github mirror used for the currently bundling of boringssl in
>     devel/grpc (github.com/boringssl/boringssl
>     <http://github.com/boringssl/boringssl>) is an unofficial mirror that
>     seems to have died a while ago. This uses the
>     github.com/google/boringssl <http://github.com/google/boringssl>
>     mirror which seems current and updating. So
>     if we are against this change to devel/grpc we should at least update
>     the bundled version of boringssl there to the newer repo and version.
> 
>     Thanks,
>     Steve
> 
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 638 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freebsd.org/pipermail/freebsd-ruby/attachments/20170630/132f571d/attachment.sig>


More information about the freebsd-ruby mailing list