[Bug 235185] www/fcgiwrap: environment should be cleaned in /usr/local/etc/rc.d/fcgiwrap

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Sun Feb 3 10:34:10 UTC 2019


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235185

Rodrigo Osorio <rodrigo at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |Not A Bug
             Status|Open                        |Closed

--- Comment #40 from Rodrigo Osorio <rodrigo at FreeBSD.org> ---
After rethinking the arguments I don't gonna change the way www/fcgiwrap rc
script behaves. I strongly believe that it's not rc script job to sanitize the
ENV variables since service(8) is doing that for you in a better way.

I also don't wanna perform code duplication between service(8) and the
www/fcgiwrap rc script because it's bad, and it prevents future changes in
service(8) to apply to www/fcgiwrap.

Finally, I don't wanna prevent peoples to start the www/fcgiwrap server
manually with custom variables in debug purpose.

Regarding the sanitize framework discussed before, you can continue the
discussion in a new improvement PR. To me, I do not see the interest, because
once you are starting the daemon with service(8) the env is sanitized for free.

Cheers,
- rodrigo

@ John Von Essen :
Regarding the default user changes used by www/fcgiwrap, nobody is the default
because it's the less powered user in the system. Changing that breaks POLA for
sure without too much benefit for the user.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


More information about the freebsd-rc mailing list