network.subr _aliasN handling

[dteske at FreeBSD.org]

Never got a go-ahead. What I got was a complaint

that I wasn't normalizing, to which I posted a patch

and never got a response.

 

Checking the mailing list archives now…

 

http://lists.freebsd.org/pipermail/freebsd-rc/2014-February/thread.htmlhttp://lists.freebsd.org/pipermail/freebsd-rc/2014-February/thread.html <http://lists.freebsd.org/pipermail/freebsd-rc/2014-February/thread.htmlhttp:/lists.freebsd.org/pipermail/freebsd-rc/2014-February/thread.html> 

 

Yeah, conversation kinda ended with that last patch.

 

But that wouldn't have deterred me. 30+ days of

silence is equivalent to acceptance -- just that I

had noticed that the patch could be expanded to

include mdconfig{,2} scripts. Was going to wait a

full day to see if anyone balked at the expansion

to include mdconfig{,2} and then move forward.

 

Happy to move forward now that it appears that

general opinion is acceptance (and not by silence).

-- 

Devin

 

From: Jason Hellenthal [mailto:jhellenthal at dataix.net] 
Sent: Sunday, March 30, 2014 5:07 PM
To: <dteske at FreeBSD.org>
Cc: Hiroki Sato; <lists at jnielsen.net>; <rc at FreeBSD.org>; <dteske at FreeBSD.org>
Subject: Re: network.subr _aliasN handling

 

Has any of this been committed this far? I seem to recall mention of a go-ahead but unsure.

 

?

-- 

 Jason Hellenthal

 Voice: 95.30.17.6/616

 JJH48-ARIN


On Mar 30, 2014, at 17:18, <dteske at FreeBSD.org <mailto:dteske at FreeBSD.org> > wrote:






-----Original Message-----

From: dteske at FreeBSD.org <mailto:dteske at FreeBSD.org>  [mailto:dteske at FreeBSD.org]

Sent: Thursday, February 27, 2014 9:04 AM

To: 'Hiroki Sato'

Cc: jhellenthal at dataix.net <mailto:jhellenthal at dataix.net> ; lists at jnielsen.net <mailto:lists at jnielsen.net> ; rc at FreeBSD.org <mailto:rc at FreeBSD.org> ;

dteske at FreeBSD.org <mailto:dteske at FreeBSD.org> 

Subject: RE: network.subr _aliasN handling

 

-----Original Message-----

From: Hiroki Sato [mailto:hrs at FreeBSD.org]

Sent: Sunday, February 23, 2014 8:00 PM

To: dteske at FreeBSD.org <mailto:dteske at FreeBSD.org> 

Cc: jhellenthal at dataix.net <mailto:jhellenthal at dataix.net> ; lists at jnielsen.net <mailto:lists at jnielsen.net> ; rc at FreeBSD.org <mailto:rc at FreeBSD.org> 

Subject: Re: network.subr _aliasN handling

 

<dteske at FreeBSD.org <mailto:dteske at FreeBSD.org> > wrote

 in <122101cf2f94$bfd81b30$3f885190$@FreeBSD.org <mailto:122101cf2f94$bfd81b30$3f885190$@FreeBSD.org> >:

 

dt> > +list_vars()

dt> > +{

dt> > +    set | { while read LINE; do

dt> > +        var="${LINE%%=*}"

dt> > +        case "$var" in

dt> > +        "$LINE"|*[!a-zA-Z0-9_]*) continue ;;

dt> > +        $1) echo $var

dt> > +        esac

dt> > +    done; }

dt> > +}

dt> >

dt> >  This can be inconsistent with normalization of $_if in

dt> > get_if_var()

when

dt> [.-/+]

dt> > is included.

dt> >

dt> [Devin Teske]

dt>

dt> I'm not sure what you mean by "when [.-/+] is included". The line

dt> of

code

 

get_if_var() normalizes IF part in the variable name before eval:

 

|       _if=$1

|       _punct=". - / +"

|       for _punct_c in $_punct; do

|               _if=`ltr ${_if} ${_punct_c} '_'`

|       done

 

while list_vars ifconfig_${_if}_alias[0-9]\* does not.

 

I think this breaks the following configuration, for example:

 

ifconfig_bge0_name="ext.1"

ifconfig_ext_1="inet 192.168.0.1/24"

ifconfig_ext_1_alias0="inet 192.168.1.1/24"

 

 

Thanks! Didn't know about that feature. I've attached an updated patch for

review which takes this normalization into account


I was noticing /etc/rc.d/mdconfig and /etc/rc.d/mdconfig2 exhibit the same
behavior, so I've attached a new patch. I didn't find any other instances
where a break in the count would stop the loop prematurely.

No changes to the old patch, just added mdconfig{,2} to it.
-- 
Devin

_____________
The information contained in this message is proprietary and/or confidential. If you are not the intended recipient, please: (i) delete the message and all copies; (ii) do not disclose, distribute or use the message in any manner; and (iii) notify the sender immediately. In addition, please be aware that any message addressed to our domain is subject to archiving and review by persons other than the intended recipient. Thank you.

<patch.txt>

_____________
The information contained in this message is proprietary and/or confidential. If you are not the intended recipient, please: (i) delete the message and all copies; (ii) do not disclose, distribute or use the message in any manner; and (iii) notify the sender immediately. In addition, please be aware that any message addressed to our domain is subject to archiving and review by persons other than the intended recipient. Thank you.