conf/174595: /etc/rc.d/sysctl : unknown oid ' XXX' [regression]

[Jilles Tjoelker]

On Wed, Mar 13, 2013 at 09:20:00AM +0000, Olivier Smedts wrote:
> The following reply was made to PR conf/174595; it has been noted by GNATS.

> From: Olivier Smedts <olivier at gid0.org>
> To: bug-followup at FreeBSD.org, olivier at gid0.org
> Cc: delphij at freebsd.org
> Subject: Re: conf/174595: /etc/rc.d/sysctl : unknown oid 'XXX' [regression]
> Date: Wed, 13 Mar 2013 10:11:08 +0100

>  Isn't the logic inverted between the start/reload case and the
>  lastload case ?

>  The attached patch seems logical :
>  - tell sysctl to ignore unknown OIDs during the "start" case (corrects
>  the regression)
>  rationale : some klds still aren't loaded at start, my example with
>  linux_enable="YES" in rc.conf and compat.linux.osrelease=2.6.32 in
>  sysctl.conf is a common use case, and it's not meaningful / it's
>  confusing to show a startup error about a sysctl which couldn't be set
>  while it actually has been set in lastload stage
>  - tell sysctl to not ignore unknown OIDs during the "lastload" case
>  (preserve added value of r244198)
>  rationale : if an OID is really unknown and couldn't be set neither in
>  the start nor in the lastload cases, it's useful to be told about the
>  fatal error
>  - behave in the "reload" case like in the "lastload" stage
>  rationale : reloads usually happen after system startup so they're
>  really a "lastlastload", and it's useful to spit out errors about
>  unknown OIDs to the operator who asked for a reload

I think the patch is how it should be.

>  Hoping the attachment won't be stripped,

GNATS mangled the patch while forwarding the email (by indenting the
MIME structure and removing the MIME headers) but shows it correctly in
the PR.

-- 
Jilles Tjoelker