Making use of set_rcvar.

[Pawel Jakub Dawidek]

On Mon, Jan 09, 2012 at 10:40:30AM +0100, Stefan Esser wrote:
> Am 09.01.2012 00:12, schrieb Doug Barton:
> > Attached is a patch that does what I suggested a long time ago, removes
> > set_rcvar() entirely and assigns each rcvar statically. I'll commit this
> > in a few days if no one objects. (Note, it can't be committed yet
> > because the scripts in ports that call set_rcvar() have to be modified
> > first.)
> [...]
> > Index: rc.d/nscd
> > ===================================================================
> > --- rc.d/nscd	(revision 229825)
> > +++ rc.d/nscd	(working copy)
> > @@ -19,7 +19,7 @@
> >  . /etc/rc.subr
> >
> >  name="nscd"
> > -rcvar=`set_rcvar`
> > +rcvar="nscd_enable"
> 
> Why not generally use
> 
> 	rcvar="${name}_enable"
> 
> instead of (e.g.)
> 
> 	rcvar="nscd_enable"
> 
> in all scripts *in your patch set*, for which the outcome is the same?

I fully agree. There is one less thing to change after reusing a script.
I can't see how this might be a bad idea, really.

-- 
Pawel Jakub Dawidek                       http://www.wheelsystems.com
FreeBSD committer                         http://www.FreeBSD.org
Am I Evil? Yes, I Am!                     http://yomoli.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-rc/attachments/20120109/b906625d/attachment.pgp