Making use of set_rcvar.

[Pawel Jakub Dawidek]

On Sat, Jan 07, 2012 at 02:38:23PM -0800, Doug Barton wrote:
> On 01/07/2012 03:25, Pawel Jakub Dawidek wrote:
> > On Fri, Jan 06, 2012 at 05:05:58PM -0800, Doug Barton wrote:
> >> On 01/06/2012 06:13, Pawel Jakub Dawidek wrote:
> >>> Any objections?
> >>>
> >>> 	http://people.freebsd.org/~pjd/patches/set_rcvar.patch
> >>>
> >>> This patch only changes scripts where set_rcvar can be used with no
> >>> arguments.
> >>
> >> Please don't do this.
> >>
> >> Jilles already pointed out the important reason, it adds pointless
> >> forks. I suggested a long time ago that we remove set_rcvar altogether
> >> but I got a lot of resistance to it, and never pursued it. Perhaps it's
> >> time to revisit that.
> > 
> > It is a total mess now then and it is definiately not intuitive when
> > there are much more bad examples than good ones:
> 
> I agree, which is why I previously proposed assigning them all directly
> when possible (which is in almost all cases). If no one speaks up
> opposing this idea in the next few days I'm still prepared to proceed.

Don't forget to update documentation (rc(8)).

-- 
Pawel Jakub Dawidek                       http://www.wheelsystems.com
FreeBSD committer                         http://www.FreeBSD.org
Am I Evil? Yes, I Am!                     http://yomoli.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-rc/attachments/20120107/fff4f4f4/attachment.pgp