Making use of set_rcvar.

[Pawel Jakub Dawidek]

On Fri, Jan 06, 2012 at 05:05:58PM -0800, Doug Barton wrote:
> On 01/06/2012 06:13, Pawel Jakub Dawidek wrote:
> > Any objections?
> > 
> > 	http://people.freebsd.org/~pjd/patches/set_rcvar.patch
> > 
> > This patch only changes scripts where set_rcvar can be used with no
> > arguments.
> 
> Please don't do this.
> 
> Jilles already pointed out the important reason, it adds pointless
> forks. I suggested a long time ago that we remove set_rcvar altogether
> but I got a lot of resistance to it, and never pursued it. Perhaps it's
> time to revisit that.

It is a total mess now then and it is definiately not intuitive when
there are much more bad examples than good ones:

	% grep -r ^rcvar /usr/src/etc/rc.d | grep set_rcvar | wc -l
	      66
	% grep -r ^rcvar /usr/src/etc/rc.d | grep -v set_rcvar | wc -l
	      34

> In regards to your concern about not having to type the name of the
> script when copying to create a new one, you can't really be serious
> about that? If so, let me introduce you to this revolutionary thing
> called "search and replace."

Do you really expect me to comment this?

-- 
Pawel Jakub Dawidek                       http://www.wheelsystems.com
FreeBSD committer                         http://www.FreeBSD.org
Am I Evil? Yes, I Am!                     http://yomoli.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-rc/attachments/20120107/5b7492fb/attachment.pgp