Annoying ERROR: 'wlan0' is not a DHCP-enabled interface

[Doug Barton]

On 11/18/2011 13:11, Xin LI wrote:
> On 11/18/11 12:50, Doug Barton wrote:
>> On 11/18/2011 12:45, Eygene Ryabinkin wrote:
>>> Xin, good day.
>>>
>>> Fri, Nov 18, 2011 at 12:38:31PM -0800, Xin LI wrote:
>>>> Is there any counter reasoning about "having an interface
>>>> marked as non-DHCP is not an error"?  I'm still not convinced
>>>> with the benefit of having it show an error message.
>>>
>>> Well, when I invoke 'service dhclient start em0' and em0 isn't 
>>> DHCP-enabled, I want to see some diagnostics on why I was not
>>> able to get DHCP on that interface.  Return code isn't that
>>> visible (I can, of course, always run it as 'service dhclient
>>> start em0 || echo failed'), but I am not up to typing more than
>>> needed and I should see the real reason for absence of
>>> DHCP-assigned address in that case, be it the non-DHCP-enabled
>>> interface or some other problem.
> 
>> Right, that's my argument as well.
> 
>> If there is a particular code path that leads to attempting
>> dhclient on a non-dhcp interface I'd rather see that code path
>> fixed than to suppress the warning.
> 
> Do you have any objection to rea@'s version of patch?

I already said I did, yes.

Fix the real problem, don't paper over the symptom.

-- 

		"We could put the whole Internet into a book."
		"Too practical."

	Breadth of IT experience, and depth of knowledge in the DNS.
	Yours for the right price.  :)  http://SupersetSolutions.com/