[PATCH] Use printf(1) builtin for hexprint function in etc/network.subr

[Devin Teske]

On May 8, 2011, at 5:37 AM, Jilles Tjoelker wrote:

> Now that printf(1) is a shell builtin, there is no need to emulate it
> anymore.

Did you realize that when you committed printf(1) back to the sh(1) Makefile, you were about 28 hours away from the 9 year anniversary of when knu removed it. knu removed printf(1) from the sh(1) makefile on Nov 20th, 2001, and you brought it back on Nov 19th, 2010. According to:

	http://www.freebsd.org/cgi/cvsweb.cgi/src/bin/sh/Makefile


Hallelujah!! Thank you so much for bringing printf(1) back as a builtin! Anytime you're near San Francisco, I'll buy you a beer (seriously... _thank_ _you_).
-- 
Cheers,
Devin


> 
> It may be faster to use printf directly but the function is useful for
> compatibility.
> 
> Index: etc/network.subr
> ===================================================================
> --- etc/network.subr	(revision 220966)
> +++ etc/network.subr	(working copy)
> @@ -1333,38 +1333,14 @@
> #	Echo decimal number $arg (single digit) in hexadecimal format.
> hexdigit()
> {
> -	if [ $1 -lt 10 ]; then
> -		echo $1
> -	else
> -		case $1 in
> -		10)	echo a ;;
> -		11)	echo b ;;
> -		12)	echo c ;;
> -		13)	echo d ;;
> -		14)	echo e ;;
> -		15)	echo f ;;
> -		esac
> -	fi
> +	printf '%x\n' "$1"
> }
> 
> # hexprint arg
> #	Echo decimal number $arg (multiple digits) in hexadecimal format.
> hexprint()
> {
> -	local val str dig
> -	val=$1
> -	str=''
> -	dig=`hexdigit $((${val} & 15))`
> -	str=${dig}${str}
> -	val=$((${val} >> 4))
> -
> -	while [ ${val} -gt 0 ]; do
> -		dig=`hexdigit $((${val} & 15))`
> -		str=${dig}${str}
> -		val=$((${val} >> 4))
> -	done
> -
> -	echo ${str}
> +	printf '%x\n' "$1"
> }
> 
> is_wired_interface()
> 
> -- 
> Jilles Tjoelker
> _______________________________________________
> freebsd-rc at freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-rc
> To unsubscribe, send any mail to "freebsd-rc-unsubscribe at freebsd.org"

-- 
Cheers,
Devin Teske

-> CONTACT INFORMATION <-
Business Solutions Consultant II
FIS - fisglobal.com
510-735-5650 Mobile
510-621-2038 Office
510-621-2020 Office Fax
909-477-4578 Home/Fax
devin.teske at fisglobal.com

-> LEGAL DISCLAIMER <-
This message  contains confidential  and proprietary  information
of the sender,  and is intended only for the person(s) to whom it
is addressed. Any use, distribution, copying or disclosure by any
other person  is strictly prohibited.  If you have  received this
message in error,  please notify  the e-mail sender  immediately,
and delete the original message without making a copy.

-> END TRANSMISSION <-

_____________

The information contained in this message is proprietary and/or confidential. If you are not the intended recipient, please: (i) delete the message and all copies; (ii) do not disclose, distribute or use the message in any manner; and (iii) notify the sender immediately. In addition, please be aware that any message addressed to our domain is subject to archiving and review by persons other than the intended recipient. Thank you.
_____________