status cleanup
J. Hellenthal
jhell at DataIX.net
Tue Mar 29 20:33:07 UTC 2011
On Mon, 28 Mar 2011 22:59, hrs@ wrote:
> Wesley Shields <wxs at freebsd.org> wrote
> in <20110329024441.GA24720 at atarininja.org>:
>
> wx> On Fri, Mar 18, 2011 at 09:31:55PM -0400, Wesley Shields wrote:
> wx> > On Fri, Mar 18, 2011 at 09:29:59PM -0400, Wesley Shields wrote:
> wx> > > A co-worker noticed that the pf rc script has 'status' listed twice when
> wx> > > run without any arguments. The attached patch fixes that and two other
> wx> > > cases where this also happens. I've only tested the pf changes. I'd
> wx> > > appreciate a review of this and maybe a commit? I can file a PR if it
> wx> > > would make people feel better.
> wx> > >
> wx> > > I'm not subscribed to this list so I would appreciate being CC'ed on any
> wx> > > replies.
> wx> > >
> wx> > > -- WXS
> wx> >
> wx> > This time with the patch attached, or you can get it at:
> wx> >
> wx> > http://people.freebsd.org/~wxs/rc-status-cleanup.diff
>
> wx> > -extra_commands="status prefer_ipv6 prefer_ipv4"
> wx> > +extra_commands="prefer_ipv6 prefer_ipv4"
>
> For the ip6addrctl script removing "status" is wrong. This keyword
> is automatically added only when ${name}_program is defined and the
> ip6addrctl does not define it.
>
> The other two changes look good to me. If there is no objection in a
> day or two, I will commit them. Thank you for your report.
>
> -- Hiroki
>
WXS,
I have these applied here and to the best of my knowledge they are
correct as can be.
As for the status command in ip6addrctl Is it really needed ? ;) There is
no daemon running here...
+1week
--
Regards,
J. Hellenthal
(0x89D8547E)
JJH48-ARIN
More information about the freebsd-rc
mailing list