conf/163508: [rc.subr] [patch] Add " enable" and " disable" commands to rc.subr

Warner Losh imp at bsdimp.com
Sat Dec 24 16:47:33 UTC 2011


On Dec 24, 2011, at 5:30 AM, Maxim Ignatenko wrote:
> On 24 December 2011 04:15, Doug Barton <dougb at freebsd.org> wrote:
>> This idea has been considered before and rejected because it's too
>> difficult to catch all the corner cases, and actually editing a config
>> file is not really all that hard of a thing to do.
>> 
> 
> The idea was to make enabling/disabling services less error-prone. It
> don't need to catch _all_ corner cases, because if administrator do
> something unusual with startup configuration he should be able to
> manipulate it in proper way, or even have tools that do something
> similar.
> Proposed patch handles /etc/rc.conf, /etc/rc.conf.local and
> /etc/rc.conf.d/* properly (I hope), so it should fit nicely in 95% of
> cases.
> Doing `service someserive enable` is much faster and less error-prone
> that `service someservice rcvar ; echo someservicercvar_enable=YES >>
> /etc/rc.conf`

Also, let's not reject  it before it is done.  Let's reject it when it actually doesn't handle the cases that are interesting.  No sense in cutting off a good feature because of some theoretical problem.  It is a problem we have sometimes in the project... 

Warner




More information about the freebsd-rc mailing list