rc-script review request

[Garrett Cooper]

On Wed, Nov 30, 2011 at 10:21 PM, Doug Barton <dougb at freebsd.org> wrote:
> On 11/30/2011 17:14, Garrett Cooper wrote:
>>     Crazy thought -- should a script be made for rc scripts, similar
>> to portcheck?

I meant portlint, BTW.. not portcheck :).

> I look forward to reviewing your patches to implement this feature. :)

Yipes... I have some work ahead of me. portlink is 3k lines of perlness...

> Seriously though, I've thought about it, but the problem is that the
> number of variables is really high, and unlike port Makefiles there are
> very few standard elements that exist in a predetermined order.

Well, yeah.. you can't catch everything, but it wouldn't hurt to catch
basic issues so you wouldn't have to be bothered to review first
drafts of code.

> OTOH, I'd be happy to be proven wrong.

Thanks!
-Garrett