cvs commit: src/etc rc.subr

[Mike Makonnen]

On Fri, 2008-01-25 at 10:04 -0600, Brooks Davis wrote:
> On Fri, Jan 25, 2008 at 03:21:02PM +0000, Ceri Davies wrote:
> > On Fri, Jan 25, 2008 at 03:06:26PM +0000, Mike Makonnen wrote:
> > > mtm         2008-01-25 15:06:26 UTC
> > > 
> > >   FreeBSD src repository
> > > 
> > >   Modified files:
> > >     etc                  rc.subr 
> > >   Log:
> > >   If the rc.conf(5) variable for a script is not enabled do not fail
> > >   silently. Display a message that the command wasn't run and make
> > >   possible suggestions for what to do.
> > 
> > Any chance that we could make this behaviour dependent on some other
> > variable (or not do it)?  It's going to make booting look pretty nasty.
> 
> The other option I'd considered was to create a quiet precmd that works like
> force and use quietstart/quitestop for boot.  I've become convinced this is the
> right interactive behavior.
> 
> -- Brooks
> 
> > Ceri
> > 
> > > | @@ -606,6 +606,9 @@ run_rc_command()
> > > |  					#
> > > |  	if [ -n "${rcvar}" -a "$rc_arg" != "rcvar" ]; then
> > > |  		if ! checkyesno ${rcvar}; then
> > > | +			echo -n "Cannot '${rc_arg}' $name. Set ${rcvar} to "
> > > | +			echo -n "YES in /etc/rc.conf or use 'one${rc_arg}' "
> > > | +			echo "instead of '${rc_arg}'."
> > > |  			return 0
> > > |  		fi
> > > |  	fi
> > 

Ok, I went with brooks@'s suggestion and instead implemented a quiet
prefix. In addition, I also made the 'fast' prefix imply 'quiet'.

Something else this buys us is that we now have a knob that we can put a
lot of diagnostic messages behind to "de-clutter" the console during
boot and shutdown.
Patch is attached.

Cheers.
-- 
Mike Makonnen         | GPG-KEY: http://people.freebsd.org/~mtm/mtm.asc
mmakonnen @ gmail.com | AC7B 5672 2D11 F4D0 EBF8 5279 5359 2B82 7CD4 1F55
mtm @ FreeBSD.Org     | FreeBSD - http://www.freebsd.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: rc.d-quiet.diff
Type: text/x-patch
Size: 2649 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-rc/attachments/20080125/b66ea035/rc.d-quiet.bin