ftp-proxy

[Brooks Davis]

On Tue, Jul 03, 2007 at 04:42:38PM +0200, Max Laier wrote:
> On Tuesday 03 July 2007, Xin LI wrote:
> > Max Laier wrote:
> > > Hi,
> > >
> > > does the attached startup script for ftp-proxy(8) look reasonable? 
> > > Please keep me in CC as I'm not on the list, thanks.
> >
> > I think you missed the attachment :-)
> 
> strange - might be the list sanity checks again?  I did send it for sure.  
> Anyways, here we go again:
> 
> Index: defaults/rc.conf
> ===================================================================
> RCS file: /usr/store/mlaier/fcvs/src/etc/defaults/rc.conf,v
> retrieving revision 1.316
> diff -u -r1.316 rc.conf
> --- defaults/rc.conf	12 Jun 2007 17:33:23 -0000	1.316
> +++ defaults/rc.conf	3 Jul 2007 14:12:58 -0000
> @@ -154,6 +154,8 @@
>  pflog_logfile="/var/log/pflog"	# where pflogd should store the logfile
>  pflog_program="/sbin/pflogd"	# where the pflogd program lives
>  pflog_flags=""			# additional flags for pflogd
> +ftpproxy_enable="NO"		# Set to YES to enable ftp-proxy(8) for pf
> +ftpproxy_flags=""		# additional flags for ftp-proxy(8)
>  pfsync_enable="NO"		# Expose pf state to other hosts for syncing
>  pfsync_syncdev=""		# Interface for pfsync to work through
>  pfsync_syncpeer=""		# IP address of pfsync peer host
> Index: rc.d/ftp-proxy
> ===================================================================
> RCS file: rc.d/ftp-proxy
> diff -N rc.d/ftp-proxy
> --- /dev/null	1 Jan 1970 00:00:00 -0000
> +++ rc.d/ftp-proxy	3 Jul 2007 14:11:26 -0000
> @@ -0,0 +1,17 @@
> +#!/bin/sh
> +#
> +# $FreeBSD$
> +#
> +
> +# PROVIDE: ftp-proxy
> +# REQUIRE: DAEMON pf

It seems like there should be a shutdown keyword here, though for some
reason we don't include them in lots of things we could stop at shutdown
so I may be wrong.

> +#
> +
> +. /etc/rc.subr
> +
> +name="ftpproxy"
> +rcvar=`set_rcvar`
> +command="/usr/sbin/ftp-proxy"
> +
> +load_rc_-config $name

There's a stray '-' in there.

> +run_rc_command "$1"

-- Brooks
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-rc/attachments/20070703/b40e6855/attachment.pgp