rcvar function in rc.subr

[Florent Thoumie]

Alexander Botero-Lowry wrote:
>> On Sun, Nov 26, 2006 at 02:13:39PM +0000, Florent Thoumie wrote:
>>> Yar Tikhiy wrote:
>>>> On Thu, Oct 19, 2006 at 03:33:23PM +0100, Florent Thoumie wrote:
>>>>> Does anybody have a clue why /etc/rc.d/foo rcvar prints a leading '$'
>>>>> before the variable name? Doesn't make much sense with /bin/sh.
>>>> Sorry for the late reply.  According to the CVS history, the code
>>>> was just imported from NetBSD.  Perhaps it's too late to change it
>>>> as people are likely to have workarounds for it already.  Of course,
>>>> $foo_enable=YES looks ugly and has a different meaning in sh(1).
>>> Well, it may be worth fixing in HEAD even if we don't MFC the change.
>> Then just do it!  Well, if no serious objections appear in a
>> reasonable period of time.  Personally, I'm happy with the change
>> -- I'm just not enough unhappy with the current bogosity. :-)
>>
> Err, why is it a good idea to break compatability with NetBSD?
> 
> This means that tools written for rc.d that use rcvar (chkconfig clone for
> example) have to have behavior written for both NetBSD and FreeBSD instead 
> of just having consistent behavior. 

Not sure what you're thinking about. But if it's wrong, it must be
fixed. If this chkconfig clone uses rcvar command output redirected to
rc.conf, it's likely to do 's/^\$//' and it won't break anything.

Would you care to elaborate a bit more?

-- 
Florent Thoumie
flz at FreeBSD.org
FreeBSD Committer

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 250 bytes
Desc: OpenPGP digital signature
Url : http://lists.freebsd.org/pipermail/freebsd-rc/attachments/20061126/cdc2ee43/signature.pgp