conf/94377 : [patch] /etc/rc.d/sshd improperly tests random dev state

[Doug White]

The following reply was made to PR conf/94377; it has been noted by GNATS.

From: Doug White <dwhite at gumbysoft.com>
To: Rostislav Krasny <rosti.bsd at gmail.com>
Cc: Florent Thoumie <flz at FreeBSD.org>, Doug White <dwhite at FreeBSD.org>, 
    bug-followup at FreeBSD.org
Subject: Re: conf/94377 : [patch] /etc/rc.d/sshd improperly tests random dev
 state
Date: Thu, 8 Jun 2006 10:36:05 -0700 (PDT)

 On Thu, 8 Jun 2006, Rostislav Krasny wrote:
 
 > I've seen that patch just today, when it is already MFCed. I think it
 > could be simpler. Instead of
 >
 > [ "x${seeded}" != "x" ] && [ ${seeded} -eq 0 ]
 >
 > you can write just
 >
 > [ "${seeded}" = "0" ]
 >
 > and it will be still correct against sysctl failing and returning an
 > empty string.
 
 No, because if ${seeded} is empty, the shell interprets the test as
 
 [ = "0" ]
 
 which results in a syntax error. The 'x' in the first test is significant.
 
 -- 
 Doug White                    |  FreeBSD: The Power to Serve
 dwhite at gumbysoft.com          |  www.FreeBSD.org