For Review: Latest update to rcorder patch

[Brooks Davis]

On Thu, Dec 08, 2005 at 01:53:46PM -0800, Doug Barton wrote:
> Howdy,
> 
> The attached patch contains what I hope are the final tweaks to the new 
> rcorder code. It has the following changes:
> 
> 1. Silences a grep warning when an rc.d directory in $local_startup is 
> empty.
> 
> 2. Adds a variable to /etc/defaults/rc.conf called early_late_divider 
> (better name suggestions welcome) that defines the script to use to 
> separate the early and late stages, and the commensurate code in rc. This 
> makes the option configurable, which on the one hand puts a bullet in the 
> foot-shooting gun for careless admins, but on the other hand gives more 
> flexibility to those that can make use of it.
> 
> 3. Defaults the divider to mountcritlocal, instead of mountcritremote. 
> When last I talked to Brooks about this, he said that this would 
> "probably" be ok even for diskless booting, however I'm willing to make it 
> mountcritremote for now if we're not sure of this. Alternatively, we can 
> make the default mountcritlocal, and instruct diskless booters to change 
> this setting. Since I am not really involved in the diskless booting 
> stuff, I'm totally open to the consensus opinion on this. If we change it, 
> this will move the following scripts into the late stage:

Conceptually, I'm happy with this.  A few things.

 - I'd suggest explicitly stating that the only sane values
   for $early_late_divider are probably root, mountcritlocal, and
   mountcritremote.
 - diskless.8 should probably be updated to mentation that
   early_late_divider must be set to mountcritremote for the documented
   configuration to work.
 - If you want to depend on an rc.conf value in /etc/rc,
   /etc/rc.d/rcconf.sh should die.  early_late_divider is only non-zero
   every time through the loop by accident at this point.  Since
   rcconf.sh is no longer needed due to moving rc.d/initdiskless back
   to /etc/rc.initdiskless, it's safe to handle configuration in /etc/rc.

-- Brooks

-- 
Any statement of the form "X is the one, true Y" is FALSE.
PGP fingerprint 655D 519C 26A7 82E7 2529  9BF0 5D8E 8BE9 F238 1AD4
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-rc/attachments/20051208/b8969167/attachment.bin