emulators/virtualbox-ose-additions 6.1.18 fails to build while compiling mount_vboxfs.c

[parv/freebsd]

On Fri, Mar 12, 2021 at 10:42 AM parv/freebsd wrote:

> On Fri, Mar 12, 2021 at 9:59 AM parv/freebsd wrote:
>
>> On Fri, Mar 12, 2021 at 9:49 AM parv/freebsd wrote:
>> ...
>>
>
No need to build anymore as a package is now available.

Anyway ...

On FreeBSD stable/12-n232694-f2a88e74470 ...
>>>
>>> - have in /etc/make.conf to avoid use of DBUS, HAL, & WAYLAND via
>>> OPTIONS_UNSET;
>>> - using MINIMAL kernel with COMPAT_FREEBSD10 & COMPAT_FREEBSD11 only for
>>>   Firefox;
>>> - packages & ports tree (r568143) are uptodate
>>>
>>
>> I should have also mentioned that FreeBSD 12-STABLE tree is at commit
>> 623fe87b21, Mar 11, 2021.
>>
>> ... build of emulators/virtualbox-ose-additions version 6.1.18 fails to
>>> build
>>> due to "use of undeclared identifier" while compiling mount_vboxfs.c ...
>>>
>>>
>>> kBuild: Compiling mount_vboxvfs - /usr/src/sys/../sbin/mount/getmntopts.c
>>> kBuild: Compiling mount_vboxvfs -
>>> /src-build/ports-build/src-build/ports/emulators/virtualbox-ose-additions/work/VirtualBox-6.1.18/src/VBox/Additions/freebsd/mount_vboxvfs/mount_vboxvfs.c
>>> /src-build/ports-build/src-build/ports/emulators/virtualbox-ose-additions/work/VirtualBox-6.1.18/src/VBox/Additions/freebsd/mount_vboxvfs/mount_vboxvfs.c:54:2:
>>> error: use of undeclared identifier 'MNT_NOCOVER'
>>>         MOPT_STDOPTS,
>>>         ^
>>> /usr/src/sys/../sbin/mount/mntopts.h:100:2: note: expanded from macro
>>> 'MOPT_STDOPTS'
>>>         MOPT_NOCOVER,                                                   \
>>>         ^
>>> /usr/src/sys/../sbin/mount/mntopts.h:68:37: note: expanded from macro
>>> 'MOPT_NOCOVER'
>>> #define MOPT_NOCOVER            { "cover",      1, MNT_NOCOVER, 0 }
>>>                                                    ^
>>> /src-build/ports-build/src-build/ports/emulators/virtualbox-ose-additions/work/VirtualBox-6.1.18/src/VBox/Additions/freebsd/mount_vboxvfs/mount_vboxvfs.c:54:2:
>>> error: use of undeclared identifier 'MNT_EMPTYDIR'
>>> /usr/src/sys/../sbin/mount/mntopts.h:101:2: note: expanded from macro
>>> 'MOPT_STDOPTS'
>>>         MOPT_EMPTYDIR
>>>         ^
>>> /usr/src/sys/../sbin/mount/mntopts.h:69:41: note: expanded from macro
>>> 'MOPT_EMPTYDIR'
>>> #define MOPT_EMPTYDIR           { "emptydir",   0, MNT_EMPTYDIR, 0 }
>>>
>>
> Both of the options were added to  in Sep 2019 ...
>
>   https://reviews.freebsd.org/rS352614
> ... but do not seem to exist in FreeBSD 12 ...
>
>   # Shows nothing, unlike or '(MOPT|MNT)_RDONLY' for example.
>   % egrep -r '(MOPT|MNT)_(NOCOVER|EMPTYDIR)' sbin/mount \
>    sys/{kern,sys} lib/libc/sys
>
>
> ... so why is the port is looking for the macros/identifiers?
>
...

I suspect when the build of virtualbox-ose-additions was running, the source
tree might have not have been at "stable/12" branch. After making sure that
the tree is indeed at "stable/12", build, and thus install, had succeeded.

A "make package" had failed due to missing "$WRKSRC/../.metadir", which it
is.
Why?


- parv